User can get prompt when there is error about passwordless dependency or property. #58
Conversation
| } | ||
|
|
||
| func detectPropertySpringDatasourcePassword(azdProject *Project, springBootProject *SpringBootProject) { | ||
| var targetProperty = "spring.datasource.password" |
There was a problem hiding this comment.
Hi, @saragluna , @moarychan
Whether spring.datasource.password should be deleted in customer's application.yml when using passwordless connection?
-
Not need to delete. I tested deploy by mi, keeping this property will not cause problem.
-
Not need to delete. I checked the source code: is empty will continue the logic of passwordless.
-
It's necessary to delete. According to this doc: https://learn.microsoft.com/en-us/azure/developer/java/spring-framework/migrate-postgresql-to-passwordless-connection?tabs=sign-in-azure-cli%2Cspring%2Capp-service%2Cassign-role-service-connector
- I remember it's necessary to delete it because empty string is also a valid password for DB.
There was a problem hiding this comment.
We provide a property isPasswordlessEnabled, it should be met first. If use uses an empty password to connection db, then the isPasswordlessEnabled should be set to false, is this OK?
| detect.Services[i] = prj | ||
| // delete database | ||
| delete(detect.Databases, database) | ||
| return false, nil |
There was a problem hiding this comment.
Seems there is some problem about related code in AzureDepEventHubs, could you please fix it in another RP?
Here is the link to related PR: https://github.com/azure-javaee/azure-dev/pull/27/files
…ror-about-passwordless-dependency-or-property
rujche
deleted the
user-can-get-prompt-when-there-is-error-about-passwordless-dependency-or-property
branch
User can get prompt when there is error about passwordless dependency or property.