Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SJAD sample #56

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Fix SJAD sample #56

merged 9 commits into from
Dec 3, 2024

Conversation

saragluna
Copy link

This project will fix the https://github.com/microsoft/SJAD sample:

  • It will use the Maven wrapper in the project
  • It will identify the web project as a frontend dependency

rujche
rujche requested changes Dec 2, 2024
View reviewed changes
Copy link

@rujche rujche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the GitHub action failures.

rujche
rujche approved these changes Dec 3, 2024
View reviewed changes
cli/azd/internal/appdetect/appdetect.go
@@ -60,17 +60,19 @@ const (
PyDjango Dependency = "django"
PyFastApi Dependency = "fastapi"

SpringFrontend Dependency = "springFrontend"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use same style, change to spring-frontend

cli/azd/internal/appdetect/appdetect_test.go
JavaProjectOptionMavenParentPath: filepath.Join(dir, "java-multimodules"),
JavaProjectOptionPosixMavenWrapperPath: filepath.Join(dir, "java-multimodules", "mvnw"),
JavaProjectOptionWinMavenWrapperPath: filepath.Join(dir, "java-multimodules", "mvnw.cmd"),
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use a variable to avoid duplicated codes.

@saragluna saragluna merged commit 3947823 into azure-javaee:feature/sjad Dec 3, 2024
6 checks passed
@saragluna saragluna deleted the xiada/fix-sjad-sample branch December 3, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rujche rujche rujche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saragluna @rujche