Output resources in azure.yaml after app init #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rujche
reviewed
Oct 29, 2024
| err := marshalRawProps(raw.Props.(MySQLProps)) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Is it necessary to add other resource type like: ResourceTypeDbRedis, ResourceTypeDbPostgres, ResourceTypeDbMong?
There was a problem hiding this comment.
Could you please add unit test for MarshalYAML and UnmarshalYAML?
rujche
reviewed
Oct 29, 2024
| if err := unmarshalProps(&mp); err != nil { | ||
| return err | ||
| } | ||
| raw.Props = mp |
There was a problem hiding this comment.
Same here: Is it necessary to add other resource type like: ResourceTypeDbRedis, ResourceTypeDbPostgres, ResourceTypeDbMong?
| err := marshalRawProps(raw.Props.(MySQLProps)) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Could you please add unit test for MarshalYAML and UnmarshalYAML?
haoozhang
pushed a commit
to haoozhang/azure-dev
that referenced
this pull request
Oct 30, 2024
Use passwordless to connect to PostgreSQL in Azure Container Apps
haoozhang
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will output the resources detected from app init to
azure.yaml.