New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling as the value could exist and be empty #244

Merged

arnaudlh merged 1 commit into main from fix.envlookup

Jun 23, 2023

Contributor

LaurentLesle commented Jun 23, 2023

Issue-id

PR Checklist

I have read the CONTRIBUTING.MD instructions
I have changed the resourceDefinition.json
I have generated the resource model (there's a models_generated.go file in my PR)
I have updated the README.md#resource-status
I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

YES
NO

Testing


          Better error handling as the value could exist and be empty

31b7319

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

arnaudlh self-requested a review

June 23, 2023 09:10

arnaudlh assigned LaurentLesle

arnaudlh added the bug label

arnaudlh added this to the 1.2.26 milestone

arnaudlh approved these changes

View reviewed changes

Member

arnaudlh left a comment

LGTM

arnaudlh merged commit eacec62 into main

arnaudlh deleted the fix.envlookup branch

June 23, 2023 09:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug