Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update definition for databricks workspace name #238

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Update definition for databricks workspace name #238

merged 3 commits into from
Jun 23, 2023

Conversation

benhurjoel
Copy link
Contributor

@benhurjoel benhurjoel commented May 5, 2023 •
edited
Loading

Issue-id

PR Checklist

  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@benhurjoel benhurjoel mentioned this pull request May 5, 2023
Closed
@LaurentLesle LaurentLesle requested a review from arnaudlh May 8, 2023 06:28
@arnaudlh arnaudlh added the bug Something isn't working label Jun 23, 2023
@arnaudlh arnaudlh added this to the 1.2.26 milestone Jun 23, 2023
arnaudlh
arnaudlh approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arnaudlh arnaudlh linked an issue Jun 23, 2023 that may be closed by this pull request
azurerm_databricks_workspace character limit update #237
Closed
@arnaudlh arnaudlh changed the title update definition for databricks workspace name Update definition for databricks workspace name Jun 23, 2023
@arnaudlh
Copy link
Member

thanks for the PR @benhurjoel, good to have you back to it ;)

@arnaudlh arnaudlh merged commit 3ef6d07 into aztfmod:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@benhurjoel benhurjoel

Labels
bug Something isn't working
Projects
No open projects
2306
Status: ✅ Done
Milestone
1.2.26
Development

Successfully merging this pull request may close these issues.

azurerm_databricks_workspace character limit update
2 participants
@benhurjoel @arnaudlh