Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation #229

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Fix documentation #229

merged 2 commits into from
Mar 9, 2023

Conversation

LaurentLesle
Copy link
Contributor

Issue-id

PR Checklist


  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@arnaudlh arnaudlh self-requested a review March 9, 2023 02:17
@arnaudlh arnaudlh added the documentation Improvements or additions to documentation label Mar 9, 2023
@arnaudlh arnaudlh added this to the 1.2.24 milestone Mar 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit ec35b1c into main Mar 9, 2023
@arnaudlh arnaudlh deleted the Fix-March23 branch March 9, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants