Update to azurerm 4.7.0 #2078
Open
Update to azurerm 4.7.0 #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the version of the AzureRM provider in our Terraform configuration from 3.114.0 to 4.7.0. The upgrade may introduce new features, improvements, and bug fixes that could enhance our infrastructure management capabilities. Please review any breaking changes or deprecations introduced by this version change to ensure compatibility with existing infrastructure code.
…d to private_endpoint_network_policies refact(subnet): upgrade private_endpoint_network_policies_enabled to private_endpoint_network_policies upgrade private_endpoint_network_policies_enabled deprecated, use private_endpoint_network_policies
Description: This commit replaces the use of `storage_account_name` with `storage_share_id` in the `file_share_directory`, `directory`, and `variables` modules. This change is made to improve the referencing mechanism within these modules. The `storage_share_id` provides a more direct and efficient way to reference the Azure Storage Share, eliminating the need for the `storage_account_name`.
…remove unused variable This commit renames the variable `enable_https_traffic_only` to `https_traffic_only_enabled` in various configuration files, providing a clearer understanding of its function. The change is applied in the nfsv3 and file-share-nfs storage account examples as well as the main storage_account module. Additionally, the unused variable `share_name` has been removed from the `file_share_directory` module's variables. This reduction in code clutter should make the module easier to maintain and understand. Please note that these changes may require updates to any scripts or configurations that reference the old variable names.
- Add support for customer managed keys in Cognitive Service Account - Add support for cognitive deployments - Update Cognitive Services account with new optional parameters - Add OpenAI scenario to standalone scenarios - Update Visual Studio Code settings with new scope "subnet" - Refactor private endpoint configuration for Cognitive Services - Remove unused example "101-cognitive-services-account-managed-identity" - Rename and update example "100-cognitive-services-account" to "200-cognitive-services-account-OpenAI" - Add new examples for OpenAI configuration, including VNet and private endpoint configurations - Update local and combined objects for cognitive services This commit introduces several enhancements to the Cognitive Services module, including the ability to configure customer managed keys and cognitive deployments. It also updates the standalone scenarios and Visual Studio Code settings, refactors the private endpoint configuration, and adds new examples for OpenAI configuration.
This commit updates the MSSQL failover group resource configuration in Terraform. The changes include: - Replacing "azurerm_sql_failover_group" with "azurerm_mssql_failover_group". - Removing "resource_group_name" as it's no longer required. - Changing "server_name" to "server_id". - Modifying "partner_servers" block to "partner_server". These changes align with the updated Azure provider for Terraform and improve the accuracy of server identification by using server ID instead of name.
The disable_bgp_route_propagation variable has been renamed to bgp_route_propagation_enabled, and its logic has been inverted. This change is made to provide a more intuitive understanding of the configuration. Now, when bgp_route_propagation_enabled is true, it means that BGP route propagation is enabled, and vice versa. This change affects the modules.tf, variables.tf, and networking.tf files in the networking/route_tables module. Make sure to update any dependent configurations accordingly.
…re_directory module
…d update file_share_directory module
Body: Renamed several configuration variables in the `cosmos_db` module and examples to improve readability and consistency. The changes include: 1. Renamed `enable_automatic_failover` to `automatic_failover_enabled`. 2. Renamed `enable_free_tier` to `free_tier_enabled`. 3. Renamed `enable_multiple_write_locations` to `multiple_write_locations_enabled`. These changes apply to all Cosmos DB configurations and should make the settings more intuitive to understand. As this is a breaking change, users need to update their configuration files accordingly.
…dule and update file_share_directory module
…te instance The commit removes the 'location' property from the Azure Machine Learning Compute Instance configuration in Terraform. This change is done to rely on the default location setting provided by Azure, instead of explicitly setting it in the Terraform configuration. It simplifies our configuration and relies more heavily on Azure's defaults, reducing potential points of failure.
``` refactor(redis_cache): update variable naming for clarity Changed the names of two variables in the Azure Redis Cache module for better readability and consistency with other variable names. The 'enable_non_ssl_port' variable has been renamed to 'non_ssl_port_enabled', and the 'enable_authentication' variable has been renamed to 'authentication_enabled'. This change should not affect any functionality, but it might require updates in places where these variables are used. ```
The `integration_service_environment_id` attribute has been removed from the logic app workflow module. This change simplifies the codebase by eliminating an unused attribute, thus improving maintainability. No functional changes are expected as a result of this removal.
In this commit, we've removed all MariaDB server-related examples and associated code from the project. This includes Terraform files for creating and managing MariaDB servers, configuration files for setting up MariaDB instances, and references to MariaDB in other parts of the codebase. The decision to remove these components was made because they were no longer supported.
…l_default_retention_duration The commit replaces the 'retention_duration' attribute in the 'azurerm_data_protection_backup_policy_blob_storage' resource with 'operational_default_retention_duration'. This change aligns the module with the updated AzureRM provider, ensuring that the backup policy now uses the operational default retention duration specified in the settings.
The "incident_configuration" block has been renamed to "incident", and the "create_incident" field is now "create_incident_enabled". In addition, the "group_by_entities", "group_by_alert_details", and "group_by_custom_details" fields have been simplified to "by_entities", "by_alert_details", and "by_custom_details", respectively.
…ashicorp/azurerm to 4.7.0 This commit removes the MySQL server module and related examples. The changes include deletion of various Terraform files associated with setting up a MySQL server, including modules for database configuration, network rules, threat detection, and private endpoints. The standalone data platform workflow file was also updated to reflect these changes. This is a breaking change and will impact any existing infrastructure set up using this module.
…pe to upgrade hashicorp/azurerm to 4.7.0 This commit includes changes to the Azure Synapse Terraform modules. 1. The Azure Active Directory (AAD) admin settings have been refactored and moved from the workspace module to a new separate module called `workspace_aad_admin`. This change provides better modularity and isolation of concerns. 2. A new attribute `storage_account_type` has been added to the `sql_pool` resource with a default value of "GRS" (Geo-Redundant Storage). This allows users to specify the type of storage account to be used by the SQL pool in Azure Synapse.
…o upgrade hashicorp/azurerm to 4.7.0 Removed the dynamic `policy` block from the `azurerm_api_management` resource in the API Management module. This change simplifies the configuration by eliminating unnecessary complexity. Also removed the `soap_pass_through` attribute from the `azurerm_api_management_api` resource. This was redundant as it's not needed for our current use case. BREAKING CHANGE: No
…ace with condition_json to upgrade hashicorp/azurerm to 4.7.0
…/azurerm to 4.7.0 - Renamed and updated variables for default node pool settings in the AKS module. - Replaced deprecated variable names with new ones to align with the latest version of hashicorp/azurerm.
…upgrade hashicorp/azurerm to 4.7.0
… as an array in sql_databases.tfvars
…icies' to 'private_endpoint_network_policies' in configuration example files
…ensions to use other relative paths
…e_active_directory_role_based_access_control` block.
…in configuration files
… group object IDs fallback
…tion_duration assignment
…tric alert configuration
There was a problem hiding this comment.
Copilot reviewed 183 out of 202 changed files in this pull request and generated no suggestions.
Files not reviewed (19)
- .github/workflows/standalone-dataplat.json: Language not supported
- .github/workflows/standalone-scenarios.json: Language not supported
- .vscode/settings.json: Language not supported
- cognitive_service.tf: Language not supported
- examples/app_config/101-private-link/configuration.tfvars: Language not supported
- examples/automation/103-automation-private-endpoints/configuration.tfvars: Language not supported
- examples/cognitive_services/100-cognitive-services-account-CognitiveServices/configuration.tfvars: Language not supported
- examples/cognitive_services/100-cognitive-services-account-OpenAI/configuration.tfvars: Language not supported
- examples/cognitive_services/101-cognitive-services-account-managed-identity/configuration.tfvars: Language not supported
- examples/cognitive_services/200-cognitive-services-account-OpenAI/configuration.tfvars: Language not supported
- examples/cognitive_services/300-cognitive-services-account-OpenAI-private-endpoint/configuration.tfvars: Language not supported
- examples/cognitive_services/300-cognitive-services-account-OpenAI-vnet/configuration.tfvars: Language not supported
- examples/compute/azure_redhat_openshift/101_basic_private_cluster/vnet.tfvars: Language not supported
- examples/compute/azure_redhat_openshift/102_basic_public_cluster/vnet.tfvars: Language not supported
- examples/compute/batch/batch_account/200-batch-account-private-endpoint/configuration.tfvars: Language not supported
- examples/compute/cd-agents/agents-with-private-endpoints/networking.tfvars: Language not supported
- examples/compute/container_registry/200-acr-private-link/configuration.tfvars: Language not supported
- examples/compute/kubernetes_services/101-single-cluster/aks.tfvars: Language not supported
- examples/compute/kubernetes_services/101-single-cluster/networking.tfvars: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
…dmins with roles and members to example
…ion for backup vault example
… script extensions
…script extensions
|
@arnaudlh , is anyone there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue-id
PR Checklist
Description
Upgrade "hashicorp/azurerm" version to "~> 4.7.0"
Does this introduce a breaking change
Many resources have been modified, parameters in the code and examples have been modified.
Resources not supported by the vendor version have also been removed.
The code has been adjusted to the obsolete version so that it does not cause errors in the future.
Testing