Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devops-1901): Added configurations cdn frontdoorstandarad/premium #2006

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

reshmarajan1730
Copy link
Contributor

@reshmarajan1730 reshmarajan1730 commented Jun 11, 2024

Issue-id

PR Checklist


Description

Added feature to create azure cdn front door with standard/premium sku. Added following resources azurerm_cdn_frontdoor_custom_domain,azurerm_cdn_frontdoor_profile and other related resources

Does this introduce a breaking change

  • YES
  • NO

Testing

Tested Standalone

for cdn frontdoor profiles : FD standarad/premium
feat(devops-1901): refactor frontdoor configs
@kevindelmont
Copy link
Contributor

Hi @reshmarajan1730
Well done
You should rename cdn_front_door_profiles in cdn_frontdoor_profiles and declare it in variables.tf for this to work.

Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting error on running provided examples:

│ Error: creating Front Door Route: (Route Name "route1" / Afd Endpoint Name "endpoint1" / Profile Name "vzkk-cfdp-profile1-jsgpr" / Resource Group "vzkk-rg-front-door-rg-rwodr"): cdn.RoutesClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="Please make sure that the originGroup is created successfully and at least one enabled origin is created under the origin group."
│ 
│   with module.example.module.cdn_frontdoor_profiles["profile1"].module.cdn_frontdoor_routes["route1"].azurerm_cdn_frontdoor_route.this,
│   on ../modules/networking/cdn_frontdoor/cdn_frontdoor_routes/fd_routes.tf line 2, in resource "azurerm_cdn_frontdoor_route" "this":
│    2: resource "azurerm_cdn_frontdoor_route" "this" {
│ 
╵
╷
│ Error: creating Front Door Rule: (Rule Name "rule1" / Rule Set Name "ruleset1" / Profile Name "vzkk-cfdp-profile1-jsgpr" / Resource Group "vzkk-rg-front-door-rg-rwodr"): cdn.RulesClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="Please make sure that the originGroup is created successfully and at least one enabled origin is created under the origin group."
│ 
│   with module.example.module.cdn_frontdoor_profiles["profile1"].module.cdn_frontdoor_rules["rule1"].azurerm_cdn_frontdoor_rule.this,
│   on ../modules/networking/cdn_frontdoor/cdn_frontdoor_rules/fd_rule.tf line 1, in resource "azurerm_cdn_frontdoor_rule" "this":
│    1: resource "azurerm_cdn_frontdoor_rule" "this" {
│ 
╵

.github/workflows/standalone-networking.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants