Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Data factory iteration for global_parameter #1934

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

TjommeVergauwen
Copy link
Contributor

global_parameter should be processed as list of objects

#990 Data factory dynamic iteration not working for global_parameter

PR Checklist


Description

global_parameter is not treated correctly in the current code, resulting in an incorrect code generation and even errors.
The proposed fix solves this issue.

Does this introduce a breaking change

  • YES
  • [X ] NO

Testing

Created a data factory with 2 global parameters as follows which tested OK:

data_factory = {
data_factory = {
df_adf = {
name = "adf"
resource_group = {
key = "rg_adf"
#name = ""
}
global_parameter = {
gp_p1 = {
name = "P1"
type = "String"
value = "p1"
}
gp_p2 = {
name = "P2"
type = "String"
value = "p2"
}
}
identity = {
type = "SystemAssigned"
}
managed_virtual_network_enabled = false
}

global_parameter should be processed as list of objects
@arnaudlh arnaudlh added bug Something isn't working data factory labels Mar 14, 2024
@arnaudlh arnaudlh linked an issue Mar 14, 2024 that may be closed by this pull request
@arnaudlh arnaudlh changed the title #990: Update module.tf Fix: Data factory iteration for global_parameter Mar 14, 2024
@arnaudlh arnaudlh added this to the 5.7.10 milestone Mar 14, 2024
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit e03117c into aztfmod:main Mar 14, 2024
@arnaudlh
Copy link
Member

thanks for your contribution @TjommeVergauwen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data factory
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Data factory dynamic iteration not working for global_parameter
2 participants