Add container app module

[trapeznikov]

1301

PR Checklist

---

• I have added example(s) inside the [./examples/] folder
• I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
• I have checked the coding conventions as per the wiki
• I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

• YES
• NO

Testing

[arnaudlh]

Thanks for the PR @trapeznikov, Im running examples and getting:

│ Error: Reference to undeclared input variable
│ 
│   on module.tf line 106, in module "example":
│  106:     container_app                         = var.container_app
│ 
│ An input variable with the name "container_app" has not been declared. This variable can be declared with a variable
│ "container_app" {} block.
╵
╷
│ Error: Reference to undeclared input variable
│ 
│   on module.tf line 107, in module "example":
│  107:     container_app_dapr_component          = var.container_app_dapr_component
│ 
│ An input variable with the name "container_app_dapr_component" has not been declared. This variable can be declared with
│ a variable "container_app_dapr_component" {} block.
╵
╷
│ Error: Reference to undeclared input variable
│ 
│   on module.tf line 108, in module "example":
│  108:     container_app_environment             = var.container_app_environment
│ 
│ An input variable with the name "container_app_environment" has not been declared. This variable can be declared with a
│ variable "container_app_environment" {} block.
╵
╷
│ Error: Reference to undeclared input variable
│ 
│   on module.tf line 109, in module "example":
│  109:     container_app_environment_certificate = var.container_app_environment_certificate
│ 
│ An input variable with the name "container_app_environment_certificate" has not been declared. This variable can be
│ declared with a variable "container_app_environment_certificate" {} block.
╵
╷
│ Error: Reference to undeclared input variable
│ 
│   on module.tf line 110, in module "example":
│  110:     container_app_environment_storage     = var.container_app_environment_storage
│ 
│ An input variable with the name "container_app_environment_storage" has not been declared. This variable can be declared
│ with a variable "container_app_environment_storage" {} block.
╵
Terraform plan return code: 1
Error 1 on or near line 57: Error running terraform plan; exiting with status 1

[trapeznikov]

@arnaudlh need to add container_app to https://github.com/Azure/caf-terraform-landingzones/tree/main/caf_solution. What's the process of adding a new feature to these 2 repos? Should the change first go to caf-terraform-landingzones?

[arnaudlh]

@arnaudlh need to add container_app to https://github.com/Azure/caf-terraform-landingzones/tree/main/caf_solution. What's the process of adding a new feature to these 2 repos? Should the change first go to caf-terraform-landingzones?

1. update the module with examples working, so people can leverage it as standalone
2. update the azure repo with the new var names and module version constraint.

[trapeznikov]

@arnaudlh I fixed the variables file in the example module, it should run fine now. Sorry for the confusion, I was just testing it differently.

[mresetar-croz]

I am currently working with this PR code. I hope it gets merged soon. Maybe not the right place but please follow hashicorp/terraform-provider-azurerm#21747 as workload profiles support is something in the future that should be supported by CAF as well.

[trapeznikov]

@arnaudlh I resolved all the comment and rebased the branch. Can you please review?

[trapeznikov]

@arnaudlh @LaurentLesle can you please review this PR?

[iriahk89]

please help to add support for another 2 parameter: dapr_application_insights_connection_string & zone_redundancy_enabled. And I received error for internal_load_balancer_enabled for example 101 aca. but after I change false to null it works. I think for optional parameter we can just pass null if not specify like this:
internal_load_balancer_enabled = try(var.settings.internal_load_balancer_enabled, null)

[arnaudlh]

@trapeznikov good PR - thank you! if you dont mind adding the 2 attributes mentionned by @iriahk89, I think we are good to go!

[trapeznikov]

@arnaudlh @iriahk89 done. Please review.

[iriahk89]

@trapeznikov I reviewed the PR and would really appreciate if you could add those 2 features and resolve the minor bug as one of my customers also waiting for this resource. Let me know if you need helps. Thanks!

[iriahk89]

LGTM. we can add the integration with app insight combined object later for dapr_application_insights_connection_string if needed

[arnaudlh]

LGTM

[arnaudlh]

thanks for your contribution @trapeznikov and for your reviews @iriahk89 @jvdhaterd