Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar issues #160

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Fix grammar issues #160

merged 1 commit into from
Aug 13, 2023

Conversation

thesurlydev
Copy link
Contributor

No description provided.

@azriel91
Copy link
Owner

azriel91 commented Jul 23, 2023

Thanks!

ah, don't worry about that Rustfmt failure; they've changed quite a bit of the default formatting.


Chain of issues to get CI passing:

  1. We're affected by: needless_pass_by_ref_mut false positive for required mut reference in async function rust-lang/rust-clippy#11216
  2. We're also affected by: thread 'rustc' panicked at 'DefId(146:722 ~ libp2p_swarm[d5e9]::behaviour::NetworkBehaviour::ToSwarm) does not have a "type_of"' rust-lang/rust-clippy#11190
  3. maintenance/fmt-and-clippy branch (currently local).

2023-08-10: still fails when using:

rustc 1.73.0-nightly (f88a8b71c 2023-08-08)
clippy 0.1.73 (f88a8b7 2023-08-08)

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a12bb45) 92.45% compared to head (70a17b0) 92.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         378      378           
  Lines       35781    35781           
=======================================
  Hits        33080    33080           
  Misses       2701     2701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azriel91 azriel91 merged commit 1f3561d into azriel91:main Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants