Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate command logic for composability and single set of progress bar rendering. #130

Merged
merged 9 commits into from
Jun 7, 2023

Conversation

azriel91
Copy link
Owner

@azriel91 azriel91 commented Jun 6, 2023

Closes #120.

  • Removes hack for showing one set of progress bars.
  • Allows commands to use other commands as sub commands.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 79.08% and project coverage change: -0.12 ⚠️

Comparison is base (85cb088) 90.83% compared to head (1262889) 90.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   90.83%   90.72%   -0.12%     
==========================================
  Files         334      337       +3     
  Lines       30403    30735     +332     
==========================================
+ Hits        27618    27883     +265     
- Misses       2785     2852      +67     
Impacted Files Coverage Δ
crate/rt/src/cmds/clean_cmd.rs 50.00% <0.00%> (-50.00%) ⬇️
...e/rt/src/cmds/cmd_ctx_internal/cmd_independence.rs 0.00% <0.00%> (ø)
crate/rt/src/cmds/ensure_cmd.rs 50.00% <0.00%> (-50.00%) ⬇️
crate/rt_model_core/src/cmd_progress_tracker.rs 81.81% <ø> (+5.95%) ⬆️
crate/rt_model_native/src/output/cli_output.rs 82.45% <ø> (+1.55%) ⬆️
workspace_tests/src/items/sh_cmd_item.rs 96.68% <ø> (ø)
workspace_tests/src/items/tar_x_item.rs 99.50% <ø> (ø)
workspace_tests/src/rt/cmds/clean_cmd.rs 99.41% <ø> (ø)
workspace_tests/src/rt/cmds/ensure_cmd.rs 99.36% <ø> (ø)
...e_tests/src/rt/cmds/sub/states_desired_read_cmd.rs 98.66% <ø> (ø)
... and 10 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 force-pushed the maintenance/120/consolidate-cmd-logic branch from 725aef2 to 4bf1cb8 Compare June 6, 2023 22:41
@azriel91 azriel91 marked this pull request as ready for review June 7, 2023 03:38
@azriel91 azriel91 changed the title Consolidate command logic to have one progress bar renderer. Consolidate command logic for composability and single set of progress bar rendering. Jun 7, 2023
@azriel91 azriel91 merged commit 98122db into main Jun 7, 2023
@azriel91 azriel91 deleted the maintenance/120/consolidate-cmd-logic branch June 7, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate *Cmd logic
1 participant