Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant StatesCurrentDiscoverCmd and StatesDesiredDiscoverCmd #111

Merged

Conversation

azriel91
Copy link
Owner

@azriel91 azriel91 commented Apr 7, 2023

Closes #110.

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (bae3f7f) 92.27% compared to head (fe47161) 92.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   92.27%   92.24%   -0.04%     
==========================================
  Files         281      277       -4     
  Lines       21193    20663     -530     
==========================================
- Hits        19556    19060     -496     
+ Misses       1637     1603      -34     
Impacted Files Coverage Δ
crate/resources/src/resources.rs 100.00% <ø> (ø)
crate/resources/src/resources/ts.rs 100.00% <ø> (ø)
crate/rt/src/cmds/states_desired_display_cmd.rs 100.00% <ø> (ø)
crate/rt/src/cmds/states_saved_display_cmd.rs 100.00% <ø> (ø)
crate/rt/src/cmds/sub/apply_cmd.rs 76.14% <ø> (+0.92%) ⬆️
crate/rt/src/cmds/sub/states_desired_read_cmd.rs 100.00% <ø> (ø)
crate/rt_model_core/src/error.rs 50.00% <ø> (ø)
workspace_tests/src/resources/resources.rs 100.00% <ø> (ø)
workspace_tests/src/resources/resources/ts.rs 100.00% <ø> (ø)
crate/data_derive/src/lib.rs 99.38% <100.00%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 merged commit bc10df0 into main Apr 7, 2023
@azriel91 azriel91 deleted the maintenance/110/remove-redundant-states-discover-cmds branch April 7, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove StatesCurrentDiscoverCmd and StatesDesiredDiscoverCmd
1 participant