This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
fix(web): fix response to periodic POST requests #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason POST requests were being responded to with 400 is that in the assignment of payload, the request.json member is used if request.form evaluates as false, but accessing request.json results in an error for some requests, even though flask docs claim that the value will simply be `None`. resolves azlux#339
|
Srry to not fix that myself, I'm "working" (when I get time) on a new implementation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason POST requests were being responded to with 400 is that in the assignment of payload, the request.json member is used if request.form evaluates as false, but accessing request.json results in an error for some requests, even though flask docs claim that the value will simply be
None.resolves #339