This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
fix: Removing items during validation breaks validation #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mweinelt Would you help me check if this quick fix solved your issue? |
mweinelt
reviewed
May 16, 2021
| @@ -142,7 +146,7 @@ def item(self): | |||
| if self.id in self.lib: | |||
| return self.lib[self.id] | |||
| else: | |||
There was a problem hiding this comment.
Everything after the return is automatically an else block.
There was a problem hiding this comment.
But it does no harm to explicitly use an else statement :)
|
Haven't seen the issue again so far. |
|
Great! Thanks for testing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #266.