Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce search_opt_k_v #490

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

feat: introduce search_opt_k_v #490

wants to merge 2 commits into from

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Sep 12, 2024

Currently, there's no way to search iterable using also a key

@simPod
feat: introduce search_opt_k_v
86984c9 
Currently, there's no way to search iterable using also a key
@simPod simPod marked this pull request as ready for review September 12, 2024 12:22
@coveralls
Copy link

coveralls commented Sep 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10834142357

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.656%
Totals Coverage Status
Change from base Build 10824565385: 0.002%
Covered Lines: 5358
Relevant Lines: 5431
💛 - Coveralls

@azjezz
Copy link
Owner

azjezz commented Sep 12, 2024

we should follow existing naming convention ( e.g Vec\chunk / Vec\chunk_with_keys ).

I say we rename to Iter\search_with_keys_opt and also introduce Iter\search_with_keys for consistency.

@simPod
feat: introduce search_with_keys and search_with_keys_opt
77e44f0 
Currently, there's no way to search iterable using also a key
@simPod
Copy link
Contributor Author

simPod commented Sep 12, 2024

adapted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simPod @coveralls @azjezz