Added support for coercing stdClass to array<TKey, TValue>
#437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes azjezz#436 This change is useful when decoding JSON hashmaps into PHP hashmaps, since PHP keeps JSON-decoded data as an `stdClass` unless explicitly told to do so. Also note that preserving JSON structures as `stdClass` is sometimes very much required, since an empty hashmap is a lossy conversion to `[]` performed by `json_decode()`, when using `associative: true`. This patch makes preserving JSON data structures a bit easier. This adds some very minimal overhead to `ShapeType#coerce()`, which should be imperceptible.
Pull Request Test Coverage Report for Build 7544565365
💛 - Coveralls |
Ocramius
commented
Jan 16, 2024
veewee
added
Priority: Low
veewee
approved these changes
Jan 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436
This change is useful when decoding JSON hashmaps into PHP hashmaps, since PHP keeps JSON-decoded data as an
stdClassunless explicitly told to do so.Also note that preserving JSON structures as
stdClassis sometimes very much required, since an empty hashmap is a lossy conversion to[]performed byjson_decode(), when usingassociative: true. This patch makes preserving JSON data structures a bit easier.This adds some very minimal overhead to
ShapeType#coerce(), which should be imperceptible.