Fix mutations + math float tests

[veewee]

This PR fixes:

• Some mutation errors that are popping up
• Float related errors in PHPunit that are bugging me on mac for some while

(See #425)

[coveralls]

Pull Request Test Coverage Report for Build 6605143985

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.999%

---

Totals
Change from base Build 6487837444:	0.0%
Covered Lines:	4152
Relevant Lines:	4194

---

💛 - Coveralls

[veewee]

When the break gets transformed into a continue, it will produce the same output - yet slower.
So this is a false positive:

psl/src/Psl/Collection/Map.php

Lines 378 to 380 in 4affb62

	$u = $elements[0] ?? null;
	if (null === $u) {
	break;

[veewee]

This fallback to ?? 0 will never occur since we first check the array size.
This is a false positive:

psl/src/Psl/DataStructure/PriorityQueue.php

Line 53 in 4affb62

$priority = Math\max($keys) ?? 0;

I could solve it by doing an additional invariant check, but this seems slower for no real reason.

[veewee]

This one is actually covered - yet infection doesnt seem to be able to link the test to the mutation.

See

psl/tests/unit/Result/SuccessTest.php

Lines 34 to 42 in 4affb62

	public function testGetException(): void
	{
	$wrapper = new Success('hello');
	$this->expectException(InvariantViolationException::class);
	$this->expectExceptionMessage('No exception thrown');
	$wrapper->getThrowable();
	}

[veewee]

Hard to cover this one:

psl/src/Psl/Hash/Context.php

Lines 74 to 79 in 4affb62

	// @codeCoverageIgnoreStart
	/** @psalm-suppress ImpureFunctionCall - it creates a copy of the context, so we can consider it pure! */
	if (!hash_update($internal_context, $data)) {
	throw new Exception\RuntimeException('Unable to pump data into the active hashing context.');
	}
	// @codeCoverageIgnoreEnd

(the code coverage was already added as well.)

[veewee]

These functions were added to speed up the tests : it results in time-outs cause the iterator does not iterate anymore because it removes:

psl/src/Psl/Iter/Iterator.php

Line 181 in 4affb62

$this->next();

[veewee]

I've added some tests as well - but didnt want to go into chmodding files and testing for readability / writability at this moment.

See

psl/src/Psl/File/ReadHandle.php

Lines 25 to 35 in 4affb62

	if (!Filesystem\exists($file)) {
	throw Exception\NotFoundException::for($file);
	}
	if (!Filesystem\is_file($file)) {
	throw Exception\NotFileException::for($file);
	}
	if (!Filesystem\is_readable($file)) {
	throw Exception\NotReadableException::for($file);
	}

[veewee]

it is off by one on my system for some odd reason. Therefor I decided to check only the first 14 digits