Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of dynamic imports in collect #41

Closed
iamnurs opened this issue Mar 2, 2021 · 1 comment · Fixed by #60
Closed

Usage of dynamic imports in collect #41

iamnurs opened this issue Mar 2, 2021 · 1 comment · Fixed by #60
Assignees
@olehan
Labels
bug Something isn't working
Milestone
v1

Comments

@iamnurs
Copy link
Collaborator

iamnurs commented Mar 2, 2021

Currently rollup does not allow us to make dynamic imports of configs from workspace, that is why it is required for now to use rollup config in packages using CommonJS to be able to use them with collect. Any ideas of how to make dynamic imports work with rollup using esm
@iamnurs iamnurs mentioned this issue Mar 2, 2021
Closed
@iamnurs iamnurs added the question Further information is requested label Mar 2, 2021
@olehan olehan mentioned this issue Mar 10, 2021
Open
@olehan
Copy link
Member

olehan commented Apr 8, 2021

https://rollupjs.org/guide/en/#programmatically-loading-a-config-file

@olehan olehan added this to the v1 milestone Apr 8, 2021
@olehan olehan self-assigned this Apr 8, 2021
@olehan olehan added enhancement New feature or request and removed question Further information is requested labels Apr 8, 2021
olehan added a commit that referenced this issue Apr 8, 2021
@olehan
fix(rollup): use loadConfigFile from rollup/dist/shared to load confi…
babfa25 
…gs (#41)
olehan added a commit that referenced this issue Apr 8, 2021
@olehan
refactor: use esm configs for mono-repo example (#41)
1842d5a
@olehan olehan mentioned this issue Apr 8, 2021
Merged
@olehan olehan added bug Something isn't working and removed enhancement New feature or request labels Apr 8, 2021
@olehan olehan closed this as completed in #60 Apr 8, 2021
olehan added a commit that referenced this issue Apr 8, 2021
@olehan
fix(rollup): use loadConfigFile from rollup/dist/shared to load confi…
71ef820 
…gs (#41)
olehan added a commit that referenced this issue Apr 8, 2021
@olehan
refactor: use esm configs for mono-repo example (#41)
5b7939f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olehan olehan

Labels
bug Something isn't working
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

fix(rollup): use loadConfigFile from rollup/dist/shared to load configs (#41) azimutlabs/rollup
2 participants
@iamnurs @olehan