Skip to content

Commit

Permalink
test: workaround for gotwarlost/istanbul#690
Browse files Browse the repository at this point in the history
  • Loading branch information
FrancescoBorzi committed Jul 13, 2019
1 parent 5126098 commit cced980
Show file tree
Hide file tree
Showing 44 changed files with 44 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { CreatureEquipTemplate } from '../../../../types/creature-equip-template
})
export class CreatureEquipTemplateComponent extends SingleRowEditorComponent<CreatureEquipTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: CreatureEquipTemplateService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { LootTemplateComponent } from '../../shared/loot-template/loot-template.
})
export class CreatureLootTemplateComponent extends LootTemplateComponent<CreatureLootTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: CreatureLootTemplateService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export class CreatureOnkillReputationComponent extends SingleRowEditorComponent<
'(RewOnKillRepFaction1 and RewOnKillRepFaction2); 1 - Will give reputation to alliance players from RewOnKillRepFaction1 and ' +
'horde players from RewOnKillRepFaction2';

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: CreatureOnkillReputationService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { CreatureQuestitemService } from '../../../../services/editors/creature/
})
export class CreatureQuestitemComponent extends MultiRowEditorComponent<CreatureQuestitem> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: CreatureQuestitemService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export class CreatureTemplateAddonComponent extends SingleRowEditorComponent<Cre
public readonly CREATURE_ADDON_BYTES_1 = CREATURE_ADDON_BYTES_1;
public readonly CREATURE_ADDON_BYTES_2 = CREATURE_ADDON_BYTES_2;

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: CreatureTemplateAddonService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ export class CreatureTemplateComponent extends SingleRowEditorComponent<Creature
public readonly SPELLS_TOOLTIP = 'Spell ID that can be used for Mind Control of this creature. ' +
'For vehicle creatures: the spell on action bar with position X.';

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: CreatureTemplateService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { NpcTrainerService } from '../../../../services/editors/creature/npc-tra
})
export class NpcTrainerComponent extends MultiRowEditorComponent<NpcTrainer> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: NpcTrainerService,
public handlerService: CreatureHandlerService,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { LootTemplateComponent } from '../../shared/loot-template/loot-template.
})
export class PickpocketingLootTemplateComponent extends LootTemplateComponent<PickpocketingLootTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: PickpocketingLootTemplateService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { QueryService } from '../../../../services/query.service';
styleUrls: ['./select-creature.component.scss']
})
export class SelectCreatureComponent extends SelectComponent<CreatureTemplate> {
/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public selectService: CreatureSelectService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { LootTemplateComponent } from '../../shared/loot-template/loot-template.
})
export class SkinningLootTemplateComponent extends LootTemplateComponent<SkinningLootTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: SkinningLootTemplateService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export class SpawnsAddonComponent extends MultiRowEditorComponent<SpawnsAddon> {
public readonly CREATURE_ADDON_BYTES_1 = CREATURE_ADDON_BYTES_1;
public readonly CREATURE_ADDON_BYTES_2 = CREATURE_ADDON_BYTES_2;

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: SpawnsAddonService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export class SpawnsComponent extends MultiRowEditorComponent<Spawns> {
public readonly SPAWN_DIST_TOOLTIP = 'The maximum distance that the creature may spawn from its spawn point. ' +
'Also controls how far away the creature can walk from its spawn point if its MovementType = 1.';

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: SpawnsService,
public handlerService: CreatureHandlerService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export abstract class LootTemplateComponent<T extends LootTemplate> extends Mult
private _lootId: number;
get lootId(): number { return this._lootId; }

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: LootEditorService<T>,
protected handlerService: HandlerService<T>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export abstract class MultiRowEditorComponent<T extends TableRow> extends Editor

public readonly DTCFG = DTCFG;

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: MultiRowEditorService<T>,
protected handlerService: HandlerService<T>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { BaseSelectorModalComponent } from './base-selector-modal.component';
export abstract class SearchSelectorModalComponent extends BaseSelectorModalComponent {
public readonly DTCFG = DTCFG;

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected entityIdField: string,
protected bsModalRef: BsModalRef,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { BaseSelectorBtnComponent } from '../base-selector/base-selector-btn.com
})
export class FlagsSelectorBtnComponent extends BaseSelectorBtnComponent {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
modalService: BsModalService,
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export class FlagsSelectorModalComponent extends BaseSelectorModalComponent impl

flagValues: boolean[];

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
private flagsService: FlagsService,
protected bsModalRef: BsModalRef,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { BaseSelectorBtnComponent } from '../base-selector/base-selector-btn.com
})
export class ItemSelectorBtnComponent extends BaseSelectorBtnComponent {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
modalService: BsModalService,
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { SearchSelectorModalComponent } from '../base-selector/search-selector-m
})
export class ItemSelectorModalComponent extends SearchSelectorModalComponent {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected bsModalRef: BsModalRef,
public searchService: ItemSearchService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { BaseSelectorBtnComponent } from '../base-selector/base-selector-btn.com
})
export class SingleValueSelectorBtnComponent extends BaseSelectorBtnComponent {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
modalService: BsModalService,
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export class SingleValueSelectorModalComponent extends BaseSelectorModalComponen
public readonly DTCFG = DTCFG;
selected: Option[] = [];

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected bsModalRef: BsModalRef,
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { HandlerService } from '../../../services/handlers/handler.service';
import { EditorComponent } from './editor.component';

export abstract class SingleRowEditorComponent<T extends TableRow> extends EditorComponent<T> implements OnInit {
/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
public editorService: SingleRowEditorService<T>,
protected handlerService: HandlerService<T>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
})
export class CreatureEquipTemplateService extends SingleRowEditorService<CreatureEquipTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
})
export class CreatureLootTemplateService extends LootEditorService<CreatureLootTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { QueryService } from '../../query.service';
})
export class CreatureOnkillReputationService extends SingleRowEditorService<CreatureOnkillReputation> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
})
export class CreatureQuestitemService extends MultiRowEditorService<CreatureQuestitem> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
})
export class CreatureTemplateAddonService extends SingleRowEditorService<CreatureTemplateAddon> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { CreatureHandlerService } from '../../handlers/creature-handler.service'
})
export class CreatureTemplateService extends SingleRowEditorService<CreatureTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
1 change: 1 addition & 0 deletions src/app/services/editors/creature/npc-trainer.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
})
export class NpcTrainerService extends MultiRowEditorService<NpcTrainer> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
1 change: 1 addition & 0 deletions src/app/services/editors/creature/npc-vendor.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ NpcVendor
providedIn: 'root'
})
export class NpcVendorService extends MultiRowEditorService<NpcVendor> {
/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
})
export class PickpocketingLootTemplateService extends LootEditorService<PickpocketingLootTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
})
export class SkinningLootTemplateService extends LootEditorService<SkinningLootTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
1 change: 1 addition & 0 deletions src/app/services/editors/creature/spawns-addon.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
})
export class SpawnsAddonService extends MultiRowExternalEditorService<SpawnsAddon> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
1 change: 1 addition & 0 deletions src/app/services/editors/creature/spawns.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { QueryService } from '../../query.service';
})
export class SpawnsService extends MultiRowEditorService<Spawns> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected handlerService: CreatureHandlerService,
protected queryService: QueryService,
Expand Down
1 change: 1 addition & 0 deletions src/app/services/editors/loot-editor.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export abstract class LootEditorService<T extends LootTemplate> extends MultiRow
get entityTemplateTable(): string { return this._entityTemplateTable; }
get entityTemplateLootField(): string { return this._entityTemplateLootField; }

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected _entityClass: Class,
protected _entityTable: string,
Expand Down
1 change: 1 addition & 0 deletions src/app/services/editors/multi-row-editor.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export abstract class MultiRowEditorService<T extends TableRow> extends EditorSe
get selectedRowId(): string|number { return this._selectedRowId; }
get entitySecondIdField(): string { return this._entitySecondIdField; }

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected _entityClass: Class,
protected _entityTable: string,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { QueryService } from '../query.service';

export abstract class MultiRowExternalEditorService<T extends TableRow> extends MultiRowEditorService<T> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected _entityClass: Class,
protected _entityTable: string,
Expand Down
1 change: 1 addition & 0 deletions src/app/services/editors/single-row-editor.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { HandlerService } from '../handlers/handler.service';
export abstract class SingleRowEditorService<T extends TableRow> extends EditorService<T> {
private _originalValue: T;

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected _entityClass: Class,
protected _entityTable: string,
Expand Down
1 change: 1 addition & 0 deletions src/app/services/handlers/creature-handler.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { Router } from '@angular/router';
providedIn: 'root'
})
export class CreatureHandlerService extends HandlerService<CreatureTemplate> {
/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected router: Router,
) {
Expand Down
1 change: 1 addition & 0 deletions src/app/services/search/item-search.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
})
export class ItemSearchService extends SearchService<ItemTemplate> {

/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected queryService: QueryService,
) {
Expand Down
1 change: 1 addition & 0 deletions src/app/services/select/creature-select.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { CreatureHandlerService } from '../handlers/creature-handler.service';
providedIn: 'root'
})
export class CreatureSelectService extends SelectService<CreatureTemplate> {
/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected queryService: QueryService,
public handlerService: CreatureHandlerService,
Expand Down
1 change: 1 addition & 0 deletions src/app/services/select/select.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { HandlerService } from '../handlers/handler.service';
import { SearchService } from '../search/search.service';

export abstract class SelectService<T extends TableRow> extends SearchService<T> {
/* istanbul ignore next */ // because of: https://github.com/gotwarlost/istanbul/issues/690
constructor(
protected queryService: QueryService,
public handlerService: HandlerService<T>,
Expand Down
2 changes: 1 addition & 1 deletion src/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module.exports = function (config) {
thresholds: {
statements: 95,
lines: 95,
branches: 75, // due to https://github.com/gotwarlost/istanbul/issues/690
branches: 90,
functions: 90
}
},
Expand Down

0 comments on commit cced980

Please sign in to comment.