Add test suite for matrix of Python/Django versions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `tox` to execute a matrix of tests against the officially supported combinations of Python and Django. In addition, convert the `README` from Markdown to reStructuredText in order to appease `setup.py check`.
hectcastro
commented
May 7, 2019
| @@ -1,23 +1,26 @@ | |||
| dist: xenial | |||
There was a problem hiding this comment.
Use Xenial for everything.
| @@ -0,0 +1,175 @@ | |||
| django-ecsmanage | |||
There was a problem hiding this comment.
I didn't really want to do this, but it allows setup.py check to work.
See: pypi/warehouse#4079
| @@ -52,10 +52,10 @@ def handle(self, *args, **options): | |||
|
|
|||
| url = ( | |||
| f"https://console.aws.amazon.com/ecs/home?region={aws_region}#" | |||
| f"/clusters/{cluster_name}/tasks/{task_id}/details" | |||
| f"/clusters/{cluster_name}/tasks/{task_id}/details" # NOQA | |||
There was a problem hiding this comment.
I added these because these lines were getting marked as too long by flake8 for specific version of Python (3.4 and 3.5), despite max-line-length=88. It remains unclear why.
| @@ -0,0 +1,8 @@ | |||
| [bdist_wheel] | |||
There was a problem hiding this comment.
Configuration file for setuptools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use
toxto execute a matrix of tests against the officially supported combinations of Python and Django. In addition, convert theREADMEfrom Markdown to reStructuredText in order to appeasesetup.py check.Closes #3
Testing Instructions
Review the Travis CI build logs.