This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Add tests between indicator and serializer logic #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungjj92
force-pushed
the
feature/aggtests
branch
from
4f685d5 to
a3e5e99
Compare
CloudNiner
approved these changes
Jan 23, 2017
| split_input = agg_input.split(',') | ||
| for idx in results: | ||
| # only need to check keys from one result since all results will have identical keys | ||
| return self.assertTrue(set(split_input) == set(results[idx].keys())) |
There was a problem hiding this comment.
More than in some other places in the test suite, it might be useful to add a msg parameter here that gives a more descriptive error message than "False expected to be True". I could see it being a bit difficult to figure out whats going on and how to fix it if this test failed and I was unfamiliar with it.
From the python UnitTest docs: All the assert methods (except assertRaises(), assertRaisesRegexp()) accept a msg argument that, if specified, is used as the error message on failure
ddohler
pushed a commit
that referenced
this pull request
Aug 21, 2023
Add tests between indicator and serializer logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a test that makes sure strings input for the agg Indicator param are correctly parsed as csvs before being serialized. This arose as an issue, since fixed, in commit 439ca70, see #158
Notes
The csv string parsing happens in a place and way that can't easily be stepped into, I saw implementing these tests this way -- which is a little heavy handed.
Testing Instructions
Tests should run clean,
./scripts/testCloses #174