Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3946 Whitescreen if az_person not installed. #3947

Merged
merged 16 commits into from
Dec 13, 2024
Merged

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Dec 11, 2024

Description

Checking if az_person is enabled before counting on az_person fields.

Release notes

This release fixes a critical issue affecting AZ Quickstart 2.12.0 sites that do not have the `az_person` module installed that causes a fatal error to occur when users log in to the site.

Related issues

Closes #3946

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@trackleft trackleft requested a review from a team as a code owner December 11, 2024 23:50
@trackleft trackleft added the bug Something isn't working label Dec 11, 2024
joeparsons
joeparsons previously approved these changes Dec 11, 2024
@joeparsons joeparsons added backport Changes to be back-ported to previous minor release branch patch release Issues to be included in the next patch release labels Dec 12, 2024
@joeparsons joeparsons changed the title Fixes #3944 Whitescreen if az_person not enabled. Fixes #3946 Whitescreen if az_person not enabled. Dec 12, 2024
@joeparsons joeparsons removed the backport Changes to be back-ported to previous minor release branch label Dec 12, 2024
@joeparsons
Copy link
Member

joeparsons commented Dec 12, 2024

The affected file was added in 2.12.x only as part of #3764. If this issue also affects 2.11.x, we'll need a separate PR for that.

This should not affect 2.11.x

@joeparsons joeparsons changed the title Fixes #3946 Whitescreen if az_person not enabled. Fixes #3946 Whitescreen if az_person not installed. Dec 12, 2024
@joeparsons joeparsons requested a review from tadean December 12, 2024 00:14
joeparsons
joeparsons previously approved these changes Dec 12, 2024
@tadean
Copy link
Contributor

tadean commented Dec 12, 2024

I think to prevent other similar issues we may want to check if the field exists on the bundle, rather than checking if the module is enabled.

Copy link
Contributor

@tadean tadean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work in cases where az_person does not exist, and field_az_netid does not exist. Thanks @trackleft !

@joeparsons joeparsons added high priority Must get done for this milestone release notes labels Dec 12, 2024
@joeparsons joeparsons merged commit 4e75641 into main Dec 13, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3946 branch December 13, 2024 00:05
joeparsons added a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only bug Something isn't working high priority Must get done for this milestone patch release Issues to be included in the next patch release release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site crashes on log in if az_person not enabled.
4 participants