Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3917: Update no results views on events #3918

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

danahertzberg
Copy link
Contributor

@danahertzberg danahertzberg commented Dec 2, 2024

Description

This updates the no results text for AZ Events. Other content types do no have a field for no results.

Release notes

AZ Events are updated to have a `<p>` tag around the no results text. This is needed after the Standard text update in 2.12.0.

Related issues

Closes #3917

How to test

  1. Navigate to an event page or add an Event block to a page
  2. Observe no results text for no upcoming or no past events.
  3. Ensure spacing below text exists between text and button.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@danahertzberg danahertzberg added bug Something isn't working visual change Introduces a visual change needs-CWS-testing Needs manual pre/post release testing by Campus Web Services labels Dec 2, 2024
@danahertzberg danahertzberg self-assigned this Dec 2, 2024
@danahertzberg danahertzberg requested a review from a team as a code owner December 2, 2024 19:11
natebyerley
natebyerley previously approved these changes Dec 2, 2024
Copy link

@natebyerley natebyerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on the front end.

Screenshot 2024-12-02 at 12 44 44 PM

@danahertzberg danahertzberg dismissed natebyerley’s stale review December 4, 2024 17:25

The merge-base changed after approval.

@joeparsons joeparsons merged commit 8a41325 into main Dec 4, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3917 branch December 4, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only bug Something isn't working needs-CWS-testing Needs manual pre/post release testing by Campus Web Services release notes visual change Introduces a visual change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Paragraph is no longer added by default to no results message in views
5 participants