Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3671 Add minified option on az_bootstrap_js_info #3672

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

joshuasosa
Copy link
Contributor

Description

Adds 'minified' option on az_bootstrap_js_info similar to az_bootstrap_css_info to indicate that the file is minified.

Related issues

#3671

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@joshuasosa joshuasosa requested a review from a team as a code owner August 27, 2024 01:51
@joeparsons joeparsons added bug Something isn't working patch release Issues to be included in the next patch release labels Aug 27, 2024
Copy link
Member

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshuasosa! Great catch!

I can't believe we missed this 🤦🏻‍♂️.

@joeparsons joeparsons linked an issue Aug 27, 2024 that may be closed by this pull request
@joeparsons joeparsons added the backport Changes to be back-ported to previous minor release branch label Aug 27, 2024
@joeparsons joeparsons merged commit 5fd6c7b into main Aug 28, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3671 branch August 28, 2024 17:16
This was referenced Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Changes to be back-ported to previous minor release branch bug Something isn't working patch release Issues to be included in the next patch release
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

JS Theme Exception
4 participants