Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3639 Order Authors by Name #3640

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fixes #3639 Order Authors by Name #3640

merged 1 commit into from
Aug 14, 2024

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Aug 14, 2024

Description

This PR changes the entity list builder of author entities such that they are ordered by name rather than by id.

Ideally, I think it would be preferable to sort them by last name, first name, but that may be challenging in an entity list builder context because first and last names are fields, rather than properties of the entity itself. Currently, this PR sorts by overall name.

Related issues

#3639

How to test

  • enable az_publication and az_publication_doi
  • visit /admin/content/az-publication/import/doi
  • import doi 10.1001/jama.2013.284427
  • visit /admin/structure/az_author
  • verify that authors are sorted by name

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@tadean tadean added bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites labels Aug 14, 2024
@tadean tadean self-assigned this Aug 14, 2024
@tadean tadean requested a review from a team as a code owner August 14, 2024 16:36
@joeparsons joeparsons merged commit cdbdc3d into main Aug 14, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3639 branch August 14, 2024 17:46
joeparsons pushed a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants