Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3599 Can no longer save text format and editor configuration form, and upgrade bootstrap_utilities from 2.0.0 to 3.0.0 #3600

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Aug 2, 2024

Description

Since Drupal 10.3 (QS 2.11.x and main) there is an error when saving the config form for text formats in Quickstart.

This should allow you to save at least the standard and basic html text formatter/editors.
I've added 2 patches

Related issues

Fixes #3599

Drupal issues
https://drupal.org/i/3301133
https://drupal.org/i/3457094
https://drupal.org/i/3402570

How to test

  1. Go to /admin/config/content/formats
  2. Using the operations links, click configure for one of the mentioned text formats
  3. Scroll to the bottom of the form and click save.
  4. Open a page edit form and verify you can indent and save tables.

Testing the source mode:

  1. Create new or edit existing content using the CKEDitor source function.
  2. Add a paragraph <p class="bg-red">something</p>
  3. Toggle the Source button to see if bg-red is stripped.
  4. Try indenting the <p>
  5. Toggle the Source button to see if indenting is stripped.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@trackleft trackleft marked this pull request as ready for review August 2, 2024 22:07
@trackleft trackleft requested a review from a team as a code owner August 2, 2024 22:07
@trackleft trackleft added the bug Something isn't working label Aug 2, 2024
@trackleft trackleft self-assigned this Aug 2, 2024
@trackleft trackleft added patch release Issues to be included in the next patch release 2.11.x only labels Aug 2, 2024
bberndt-uaz
bberndt-uaz previously approved these changes Aug 2, 2024
Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to save the Basic text format successfully, but when I try to save the Standard text format, I get this error message:

image

We are currently using a patch from this Drupal core issue, which we added in this Quickstart PR: Closes #3113 Standard text format cannot be edited in the UI without removing allowed tags. Perhaps we should replace the patch with the merge request @joeparsons created recently?

@joeparsons
Copy link
Member

joeparsons commented Aug 2, 2024

I was able to save the Basic text format successfully, but when I try to save the Standard text format, I get this error message:

image We are currently using a patch from [this Drupal core issue](https://www.drupal.org/project/drupal/issues/3410100), which we added in this Quickstart PR: [Closes #3113 Standard text format cannot be edited in the UI without removing allowed tags](https://github.com//pull/3114). Perhaps we should replace the patch with [the merge request](https://www.drupal.org/project/drupal/issues/3410100#comment-15707744) @joeparsons created recently?

The MR on that issue is an incomplete fix IMHO. The patch we've been using just disables/removes the problematic constraint entirely. Not sure why that patch isn't working here. Especially since the existing patch still applies (?)

bberndt-uaz
bberndt-uaz previously approved these changes Aug 5, 2024
Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new patch, I was able to save the Standard text format configuration successfully.

image

@trackleft trackleft mentioned this pull request Aug 7, 2024
32 tasks
joeparsons
joeparsons previously approved these changes Aug 7, 2024
composer.json Outdated Show resolved Hide resolved
@trackleft trackleft dismissed stale reviews from joeparsons and bberndt-uaz via c13db12 August 8, 2024 17:53
Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Probo again and was able to save the Standard text format configuration successfully. In a text paragraph, I was able to set the alignment and indentation for some text, which results in classes being added to the <p> element. (Applying text styles from the Styles dropdown creates a <span> element with classes instead.)

@trackleft trackleft changed the title Fix #3599 Can no longer save text format and editor configuration form Fix #3599 Can no longer save text format and editor configuration form, and upgrade bootstrap_utilities from 2.0.0 to 3.0.0 Aug 8, 2024
@joeparsons joeparsons merged commit 37ef33f into main Aug 9, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3599 branch August 9, 2024 17:24
joeparsons pushed a commit that referenced this pull request Aug 9, 2024
…m, and upgrade bootstrap_utilities from 2.0.0 to 3.0.0 (#3600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only bug Something isn't working patch release Issues to be included in the next patch release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Can no longer save the Standard text formatter and editor configuration form
4 participants