-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3599 Can no longer save text format and editor configuration form, and upgrade bootstrap_utilities from 2.0.0 to 3.0.0 #3600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to save the Basic text format successfully, but when I try to save the Standard text format, I get this error message:
We are currently using a patch from this Drupal core issue, which we added in this Quickstart PR: Closes #3113 Standard text format cannot be edited in the UI without removing allowed tags. Perhaps we should replace the patch with the merge request @joeparsons created recently?
The MR on that issue is an incomplete fix IMHO. The patch we've been using just disables/removes the problematic constraint entirely. Not sure why that patch isn't working here. Especially since the existing patch still applies (?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Probo again and was able to save the Standard text format configuration successfully. In a text paragraph, I was able to set the alignment and indentation for some text, which results in classes being added to the <p>
element. (Applying text styles from the Styles dropdown creates a <span>
element with classes instead.)
…m, and upgrade bootstrap_utilities from 2.0.0 to 3.0.0 (#3600)
Description
Since Drupal 10.3 (QS
2.11.x
andmain
) there is an error when saving the config form for text formats in Quickstart.This should allow you to save at least the standard and basic html text formatter/editors.
I've added 2 patches
Related issues
Fixes #3599
Drupal issues
https://drupal.org/i/3301133
https://drupal.org/i/3457094
https://drupal.org/i/3402570
How to test
Testing the source mode:
<p class="bg-red">something</p>
<p>
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist