Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3292: Move modules out from experimental status #3465

Closed
wants to merge 9 commits into from

Conversation

danahertzberg
Copy link
Contributor

@danahertzberg danahertzberg commented Jun 4, 2024

Description

Moves modules out from experimental status

  • Do I need a DB update? - Thinking not

Related issues

Closes #3292

How to test

  1. Open module list
  2. See that listed modules are no longer in experimental group

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danahertzberg danahertzberg self-assigned this Jun 4, 2024
@danahertzberg danahertzberg linked an issue Jun 4, 2024 that may be closed by this pull request
@danahertzberg danahertzberg marked this pull request as ready for review June 4, 2024 19:03
@danahertzberg danahertzberg requested a review from a team as a code owner June 4, 2024 19:03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is ready to be marked stable.

@tadean
Copy link
Contributor

tadean commented Jun 5, 2024

Some things to possibly consider:

@@ -2,7 +2,7 @@ name: 'Quickstart Digital Asset Library'
type: module
description: 'The connector for the centralized University of Arizona Digital Asset Library (IntelligenceBank DAM).'
core_version_requirement: ^9 || ^10
package: 'The University of Arizona - Experimental'
package: 'The University of Arizona'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look into issues on quickstart.arizona.edu with this module

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall what the issue was and I was able to embed a DAL photo just fine on a draft QS page. @camikazegreen Do you have any more specifics I should look into?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was related to the login screen not using the included config to pre-fill with the appropriate settings to login.
I'm also ok with considering this to be a site specific issue that does not need to be resolved to move this module to stable. I haven't seen it happen to any other sites.

@danahertzberg
Copy link
Contributor Author

danahertzberg commented Jun 5, 2024

Need to add documentation to RELEASES.md for converting modules from experimental to stable.

  • New features without bugs for period of time
  • Features that are not expecting any further changes

@camikazegreen to make new issue and PR for this update.

@camikazegreen
Copy link
Contributor

Need to add documentation to RELEASES.md for converting modules from experimental to stable.

* New features without bugs for period of time

* Features that are not expecting any further changes

@camikazegreen to make new issue and PR for this update.

This PR is ready for review: #3477

@danahertzberg
Copy link
Contributor Author

Closing in favor of having module-specific changes. See linked issue for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Clean up experimental modules
3 participants