Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drupal/workbench_access requirement from 2.0.1 to 2.0.3 #3406

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 7, 2024

Updates the requirements on drupal/workbench_access to permit the latest version.

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on drupal/workbench_access to permit the latest version.

---
updated-dependencies:
- dependency-name: drupal/workbench_access
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner May 7, 2024 22:47
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels May 7, 2024
@trackleft
Copy link
Member

trackleft commented May 7, 2024

@joeparsons joeparsons added 2.11.x only needs-CWS-testing Needs manual pre/post release testing by Campus Web Services Drupal Waiting on a fix from the Drupal community labels May 10, 2024
@danahertzberg
Copy link
Contributor

Needs testing on Probo and multidevs

  • Ensure workbench access is working as expected
  • Test on new sites with newly enabled workbench access
  • Test on existing sites with workbench access already enabled and configured

joeparsons
joeparsons previously approved these changes Jun 26, 2024
@bberndt-uaz
Copy link
Contributor

Tested in Probo and with this multidev of a departmental site: I didn't notice any issues. However, I wasn't sure of how to test for this new Workbench Access issue: WBA per user cache context is too broad - applies to many all operations. Would this be a blocker?

@joeparsons
Copy link
Member

Tested in Probo and with this multidev of a departmental site: I didn't notice any issues. However, I wasn't sure of how to test for this new Workbench Access issue: WBA per user cache context is too broad - applies to many all operations. Would this be a blocker?

Additional test: ensure that pages that workbench access is restricting editor access for are still cacheable. This will probably require inspecting response headers for those pages to ensure cache-ability is not restricted.

@joeparsons
Copy link
Member

Next steps: determine whether to include this in a 2.11.x patch release, wait for another module release, or wait until 2.12.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 26, 2024

A newer version of drupal/workbench_access exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@bberndt-uaz bberndt-uaz changed the title Update drupal/workbench_access requirement from 2.0.1 to 2.0.2 Update drupal/workbench_access requirement from 2.0.1 to 2.0.3 Aug 12, 2024
@trackleft
Copy link
Member

I don't think this issue https://www.drupal.org/project/workbench_access/issues/3447476 should stop us from merging.

@joeparsons joeparsons merged commit e3d0834 into main Aug 13, 2024
16 checks passed
@joeparsons joeparsons deleted the dependabot/composer/drupal/workbench_access-2.0.2 branch August 13, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community needs-CWS-testing Needs manual pre/post release testing by Campus Web Services php Pull requests that update Php code
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants