Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #3385 Remove redundant permissions in "Content Administrator" role. #3388

Merged
merged 2 commits into from
May 3, 2024

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Apr 30, 2024

Description

This PR removes the the following permissions from the content administrator role that have a corresponding entry in the content editor role.

Related issues

Close #3385

How to test

Check the permissions page for any permissions that have more than one check (aside from the administrator role)

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Release Notes

Important: Content Administrators may lose access permissions if they are not also assigned the Content Editor role. Ensure all users have appropriate roles by reviewing the roles section of the managing users documentation.

@trackleft trackleft requested a review from a team as a code owner April 30, 2024 21:05
@trackleft trackleft added low priority Nice to have for this milestone, can be pushed out if needed patch release Issues to be included in the next patch release labels Apr 30, 2024
@danahertzberg
Copy link
Contributor

Would it be worth it to clean up other permissions as well?

All of the following permissions are currently enabled for Content editor and Content administrator roles.

Proposal: Remove the following permissions from the Content administrator role

Node

Administer content
Warning: Give to trusted roles only; this permission has security implications. Promote, change ownership, edit revisions, and perform other tasks across all content types.

Media

Audio: Edit own media

Content Moderation

Editorial workflow: Use Create New Draft transition.
Move content from Draft, Published states to Draft state.

Editorial workflow: Use Publish transition.
Move content from Draft, Published, Unpublished states to Published state.

Editorial workflow: Use Unpublish transition.
Move content from Draft, Published, Unpublished states to Unpublished state.

View any unpublished content

View the latest version
Requires the "View any unpublished content" or "View own unpublished content" permission

@joeparsons joeparsons added the enhancement New feature or request label May 1, 2024
@joeparsons joeparsons changed the title Close #3385 Remove Duplicate Permission in "Content Administrator Role" for "Access Draggable Views" Close #3385 Remove redundant permissions in "Content Administrator" role. May 1, 2024
@trackleft trackleft added 2.11.x only and removed patch release Issues to be included in the next patch release labels May 1, 2024
@joeparsons joeparsons merged commit b77a354 into main May 3, 2024
15 checks passed
@joeparsons joeparsons deleted the issue/3385 branch May 3, 2024 17:58
@camikazegreen
Copy link
Contributor

It looks like this permission should probably be reserved for Content Admins:

Editorial workflow: Use Publish transition.
Move content from Draft, Published, Unpublished states to Published state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only enhancement New feature or request low priority Nice to have for this milestone, can be pushed out if needed
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove duplicate permissions
5 participants