Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3365: Set Easy Breadcrumb preferred menu setting to main menu by default. #3366

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Apr 19, 2024

Description

  • Adds a default value for the "Preferred menu to use as menu title source" Easy breadcrumb module setting.
  • Re-saved and re-exported settings

Related issues

Closes #3365

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joeparsons joeparsons added enhancement New feature or request usability Improvements to usability of Quickstart components editor experience Improvements to the editor experience for individuals editing Quickstart websites labels Apr 19, 2024
@joeparsons joeparsons self-assigned this Apr 19, 2024
@joeparsons joeparsons requested a review from a team as a code owner April 19, 2024 20:38
@joeparsons
Copy link
Member Author

joeparsons commented Apr 19, 2024

Most of the changes to the file are just due to config key re-ordering.

These new settings were also added after saving and re-exporting the settings:

remove_repeated_segments_text_only: false
home_segment_validation_skip: false

These additions seem to be related to this module change:
https://www.drupal.org/project/easy_breadcrumb/issues/3347238

Copy link
Contributor

@danahertzberg danahertzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a db update?

@trackleft
Copy link
Member

trackleft commented Apr 24, 2024

@trackleft trackleft merged commit dfacf2c into main Apr 24, 2024
14 of 15 checks passed
@trackleft trackleft deleted the issue/3365 branch April 24, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor experience Improvements to the editor experience for individuals editing Quickstart websites enhancement New feature or request usability Improvements to usability of Quickstart components
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Configure Easy Breadcrumb preferred menu setting with main menu by default
3 participants