Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3151 Update NodeJS in ProboCI config to version 20.13.0. #3152

Merged
merged 11 commits into from
May 17, 2024

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Feb 5, 2024

Description

Updated the version that probo updates node to in .probo.yml
Updated some of the javascript packages we use in Quickstart
Updated the eslintrc config for Drupal 10.2
Updated the artifact javascript files. with lando yarn run build

Related issues

Closes #3151

How to test

Check the probo log. https://app.probo.ci/#/dashboard/build/93a72410-486d-4ad4-ad33-f6e3c499839e/task/635ee85e19000004

Ensure az_select_menu and az_ajax still work.
Place a select menu somewhere following these instructions: https://quickstart.arizona.edu/site-admin/managing-menus/select-menu

The az_ajax js, manifests itself on this page. /pages/news-view-paragraphs
See:

az-ajax.mov

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@trackleft trackleft requested a review from a team as a code owner February 5, 2024 23:36
@trackleft trackleft added ci Continuous integration / automation dependencies Pull requests that update a dependency file labels Feb 6, 2024
@trackleft
Copy link
Member Author

@joeparsons joeparsons added the enhancement New feature or request label Feb 7, 2024
package.json Outdated Show resolved Hide resolved
@joeparsons
Copy link
Member

Maybe we should update the eslint config, too?
https://git.drupalcode.org/project/drupal/-/blob/10.2.x/core/.eslintrc.json

@trackleft
Copy link
Member Author

trackleft commented Feb 9, 2024

Update lando file https://github.com/az-digital/az_quickstart/blob/main/.lando.yml#L50
Update ddev config

@trackleft
Copy link
Member Author

Looks like lando has a bug that does not allow installing node:20 at the moment. lando/node#66

.lando.yml Show resolved Hide resolved
.probo.yaml Outdated Show resolved Hide resolved
@joeparsons joeparsons changed the title Closes #3151 Update NodeJS in ProboCI config to version 20.11.0. Closes #3151 Update NodeJS in ProboCI config to version 20.13.0. May 10, 2024
@joeparsons joeparsons merged commit 1b7412c into main May 17, 2024
15 checks passed
@joeparsons joeparsons deleted the issue/3151-node-version-probo branch May 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only ci Continuous integration / automation dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Probo instructions to install a more recent version of Node.
3 participants