Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2663 - Allow multiple access schemes with Workbench Access #2664

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

akslay
Copy link
Contributor

@akslay akslay commented Aug 16, 2023

Description

Adds a patch that addresses a bug preventing you from having multiple access schemes in combination with the "Deny access to unassigned content" setting.

Related issues

Closes #2663

How to test

In a fresh QS build (not using this PR):

  • Install Workbench Access
  • Add 2 user accounts for testing, and assign them the "Content Editor" role (not "Content Admin")
  • Set up a couple sections on the website (or use AZQS demo content)
  • In Workbench Access settings, enable the "Deny access to unassigned content" setting
  • Create an Access Scheme, using menus, for one section of the site, and assign one of your users to it
  • Create another Access Scheme, using menus, for another section of the site, and assign your other user to it
  • Use Masquerade to try editing the 2 sections of the site using both editor accounts.

This test should fail (i.e., user assigned to section 1 shouldn't be able to actually edit it)

In Probo build:

  • Install Workbench Access
  • Add 2 user accounts for testing, and assign them the "Content Editor" role (not "Content Admin")
  • Set up a couple sections/pages on the website (or use AZQS demo content)
  • In Workbench Access settings, enable the "Deny access to unassigned content" setting
  • Create an Access Scheme for one section of the site, using menus, and assign one of your users to it
  • Create another Access Scheme for another section of the site, using menus, and assign your other user to it
  • Use Masquerade to try editing the 2 sections of the site using both editor accounts

You should now be able to edit the appropriate sections, and be denied to the appropriate sections.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@akslay akslay added the bug Something isn't working label Aug 16, 2023
@akslay akslay requested a review from a team August 16, 2023 20:14
@akslay akslay self-assigned this Aug 16, 2023
@joeparsons joeparsons added the dependencies Pull requests that update a dependency file label Aug 16, 2023
Copy link
Member

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some coding standards and D10 compatibility issues with the existing patch. Could switch to this newer patch I added to the issue?
https://www.drupal.org/project/workbench_access/issues/2982550#comment-15194961

Also, the patches section is supposed to be alphabetized (by project name). Could you move the new patch definition within the patches section so that it is in the correct alphabetical order?

composer.json Outdated Show resolved Hide resolved
Co-authored-by: Joe Parsons <[email protected]>
@joeparsons joeparsons requested review from a team and joeparsons August 16, 2023 21:33
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Aug 16, 2023
@joeparsons joeparsons merged commit 486587f into main Aug 18, 2023
@joeparsons joeparsons deleted the issue/2663 branch August 18, 2023 17:43
joeparsons added a commit that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file patch release Issues to be included in the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workbench Access denies users with appropriate permissions when multiple access schemes defined
3 participants