Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2639: Fix deprecation warning for cards with link title value and no link URL value. #2641

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Aug 7, 2023

Description

Ensures value passed to ltrim() (via Drupal\Core\Path\PathValidator->getUrlIfValid()) is a string (not NULL).

Related issues

Closes #2639

How to test

  • Add a card to Cards paragraph a flexible page with a link title but no link URL
  • Save page
  • View page
  • Verify no deprecation warning is generated or logged

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joeparsons joeparsons requested a review from a team as a code owner August 7, 2023 23:08
@joeparsons joeparsons self-assigned this Aug 7, 2023
@joeparsons joeparsons added bug Something isn't working patch release Issues to be included in the next patch release labels Aug 7, 2023
@joeparsons joeparsons changed the title Closes #2639: Fix deprecation warning generated for cards with link title value and no link URL value. Closes #2639: Fix deprecation warning for cards with link title value and no link URL value. Aug 7, 2023
Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a 2.7.1 sandbox and reproduced the error that is logged when adding a card which has a Card Link Title with no Card Link URL. Tested in Probo and confirmed that no error is logged in the same situation.

@trackleft trackleft merged commit 7fff9db into main Aug 9, 2023
@trackleft trackleft deleted the issue/2639 branch August 9, 2023 17:23
joeparsons added a commit that referenced this pull request Aug 23, 2023
trackleft pushed a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch release Issues to be included in the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning when rendering cards with link title value and no link URL value
4 participants