-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2619 News export API empty value handling #2620
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadean
added
enhancement
New feature or request
Integrations
This relates to an integration into a central service.
2.7.x only
trellis
Work associated with Trellis
labels
Jul 28, 2023
joeparsons
previously approved these changes
Jul 28, 2023
joeparsons
added
patch release
Issues to be included in the next patch release
needs discussion
Further discussion required to determine requirements
labels
Jul 28, 2023
Updated with an alternate experimental approach that adds a Normalizer service that ensures that properties the schema defines as json objects will still be serialized as objects when empty. |
joeparsons
approved these changes
Aug 18, 2023
trackleft
approved these changes
Aug 18, 2023
Kim Rosema on the Trellis team reported that the current approach in this PR of providing an empty object seems to resolve the issue with the integration on their end. |
joeparsons
pushed a commit
that referenced
this pull request
Aug 23, 2023
danahertzberg
added a commit
that referenced
this pull request
Aug 29, 2023
* Fixes #2619 News export API empty value handling (#2620) * Closes #2677: Fix broken Google Tag config upgrade. (#2678) * Fixes #2680 News Content Topic and Audiences Attributes only (#2681) * Closes #2549 remove horizontal scroll in mobile browsers when off canvas nav buttons appear on the page. (#2673) * Closes #2645: Add events to Quickstart for Marketing Cloud module (#2666) --------- Co-authored-by: tadean <[email protected]> Co-authored-by: Joe Parsons <[email protected]> Co-authored-by: Chris Green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.7.x only
enhancement
New feature or request
Integrations
This relates to an integration into a central service.
needs discussion
Further discussion required to determine requirements
patch release
Issues to be included in the next patch release
trellis
Work associated with Trellis
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some of the API fields,
az_quickstart/export/az_news/v1/az_news.json
represents empty values as[ ]
, when the value of the equivalent non-empty field is normally a json object containing the field properties (this includes fields likefield_az_media_thumbnail_image
,field_az_enterprise_attributes
andfield_az_media_image
.)This PR changes handling of those fields to produce
null
rather than[ ]
when those fields are empty. This is to increase data type consistency of the API.Discussion for review: is
null
or an empty object (rather than an array) preferable?update: the PR has been updated to instead provide an empty object
{ }
, rather thannull
.Related issues
Closes #2619
How to test
az_news_export
az_enterprise_attributes_import
az_quickstart/export/az_news/v1/az_news.json
and verify that empty field values producenull
rather than[ ]
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist