Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2382 - Fix PHP 8 code deprecation in custom smart_date migrate plugin. #2444

Merged
merged 1 commit into from
May 31, 2023

Conversation

akslay
Copy link
Contributor

@akslay akslay commented May 24, 2023

Description

Fixes a PHP 8 code deprecation error when installing AZ Demo module.

Related issues

Closes #2382

How to test

Install AZ Demo & check error logs

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@akslay akslay added the bug Something isn't working label May 24, 2023
@akslay akslay requested a review from a team as a code owner May 24, 2023 23:13
@akslay akslay self-assigned this May 24, 2023
Copy link
Member

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joeparsons joeparsons changed the title Closes #2382 - Fix PHP 8 code deprecation Closes #2382 - Fix PHP 8 code deprecation in custom smart_date migrate plugin. May 25, 2023
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label May 25, 2023
@joeparsons joeparsons merged commit eab90d2 into main May 31, 2023
@joeparsons joeparsons deleted the issue/2382 branch May 31, 2023 17:26
trackleft pushed a commit that referenced this pull request Jun 7, 2023
@trackleft trackleft mentioned this pull request Jun 16, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch release Issues to be included in the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning when installing AZ Demo Content
5 participants