Closes #2417: Fix double-encoded publication file URLs.

[joeparsons]

Description

Fixes issue with publication filenames containing special characters getting double-encoded by CiteProc.

Not exactly an ideal fix but seems to work.

Related issues

Closes #2417

How to test

• Add a file with spaces in the filename to the Publication File field in a publication.
• Ensure the link rendered in the publication citation isn't double-encoded.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

• Patch release changes
  • Bug fix
  • Accessibility, performance, or security improvement
  • Critical institutional link or brand change
  • Adding experimental module
  • Update experimental module
• Minor release changes
  • New feature
  • Breaking or visual change to existing behavior
  • Upgrade experimental module to stable
  • Enable existing module by default or database update
  • Non-critical brand change
  • New internal API or API improvement with backwards compatibility
  • Risky or disruptive cleanup to comply with coding standards
  • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
• Other or unknown
  • Other or unknown

Drupal core

• Patch release changes
  • Security update
  • Patch level release (non-security bug-fix release)
  • Patch removal that's no longer necessary
• Minor release changes
  • Major or minor level update
• Other or unknown
  • Other or unknown

Drupal contrib projects

• Patch release changes
  • Security update
  • Patch or minor level update
  • Add new module
  • Patch removal that's no longer necessary
• Minor release changes
  • Major level update
• Other or unknown
  • Other or unknown

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[joeparsons]

@JoeLutovsky ProboCI site URL for review:
https://9b7902ce-8cc1-4a9c-b4aa-cc1ed08e6449.probo.build/

[tadean]

This seems to work to resolve the double escaping in my testing. I think it's a reasonable solution - perhaps this can be reconciled in the future with a little refactoring of how currently the possible links for the title are coming from a variety of places.

[bberndt-uaz]

Tested in Probo: a publication file with spaces in the filename is correctly linked. A publication file with spaces replaced by %20 is also correctly linked, but the URL for the linked file includes %2520 in place of %20.