-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #2424 Adding badge display for all default taxonomy vocabularies. #2425
Conversation
This seems like a great change, but I can't figure out how to test this. If anyone else is able to "Add taxonomy as rendered entity to any display mode, and choose Badge", I will be happy to review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement. Don't see any issues with adding these.
@trackleft I'm not sure what's in the scope of this PR, but I wanted to note a couple things:
<div class="field field--name-field-az-page-category field--type-entity-reference field--label-hidden field__items"><a href="/pages/split-screen-no-sidebar" class="field-group-link card-body p-0" hreflang="en">
</a>
<div class="field__item"><a href="/pages/split-screen-no-sidebar" class="field-group-link card-body p-0" hreflang="en"></a>
<div id="taxonomy-term-67" class="taxonomy-term vocabulary-az-page-categories"><a href="/pages/split-screen-no-sidebar" class="field-group-link card-body p-0" hreflang="en">
</a>
<div class="content"><a href="/pages/split-screen-no-sidebar" class="field-group-link card-body p-0" hreflang="en">
</a><a href="/page-categories/split-screen" class="field-group-link badge badge-light badge-link" hreflang="en">
<div>
<div class="field field--name-name field--type-string field--label-hidden field__item">Split Screen</div>
</div>
</a>
</div>
</div>
</div>
<div class="field__item">
<div id="taxonomy-term-65" class="taxonomy-term vocabulary-az-page-categories">
<div class="content">
<a href="/page-categories/no-sidebar" class="field-group-link badge badge-light badge-link" hreflang="en">
<div>
<div class="field field--name-name field--type-string field--label-hidden field__item">No Sidebar</div>
</div>
</a>
</div>
</div>
</div>
</div> For the Person taxonomy terms, it looks like we added a field template and custom CSS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking it'd be good to merge this sooner rather than later and figure out additional implementation details like the things @bberndt-uaz mentioned as a follow-up.
Description
Implemented the az_badge display for all default taxonomy vocabularies so that we can use them in additional displays.
Related issues
Related to #2406
Related to #2423
Related to #2398
How to test
Add taxonomy as rendered entity to any display mode, and choose Badge.
Types of changes
Enhancement.
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist