Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2378 Academicpuma/locales abandoned #2379

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fixes #2378 Academicpuma/locales abandoned #2379

merged 1 commit into from
Apr 27, 2023

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Apr 27, 2023

Builds are currently failing because academicpuma/locales has reverted to only having a master branch, whereas we require 1.0.0 in our composer.json. This is likely related to the fact that academicpuma/locales was originally a clone of citation-style-language/locales (which was not available on packagist until recently). It appears the maintainer of academicpuma/locales may be intending to abandon the package now that citation-style-language/locales is available on packagist.

This PR does not contain the API-related change of referenced styles discussed in #2313

Related issues

#2378

How to test

  • Perform a build
  • enable az_publication
  • create a publication
  • Verify that publication citations still are displayed

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tadean tadean added bug Something isn't working backport Changes to be back-ported to previous minor release branch high priority Must get done for this milestone labels Apr 27, 2023
@tadean tadean requested a review from joeparsons April 27, 2023 16:28
@tadean tadean self-assigned this Apr 27, 2023
@tadean tadean requested a review from a team as a code owner April 27, 2023 16:28
Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Probo I was able to enable the publications module, create a publication, and change the default citation style to display the publication with different styles.

@joeparsons joeparsons added patch release Issues to be included in the next patch release and removed backport Changes to be back-ported to previous minor release branch labels Apr 27, 2023
@joeparsons joeparsons merged commit 4978f82 into main Apr 27, 2023
@joeparsons joeparsons deleted the bug/2378 branch April 27, 2023 17:04
@trackleft trackleft mentioned this pull request Jun 16, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Must get done for this milestone patch release Issues to be included in the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants