-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2363: Use arm64-compatible webdriver image for lando. #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeparsons
added
bug
Something isn't working
ci
Continuous integration / automation
labels
Apr 22, 2023
trackleft
previously approved these changes
Apr 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me
tadean
reviewed
Apr 28, 2023
After merging |
Co-authored-by: tadean <[email protected]>
Thanks @tadean! |
joeparsons
changed the title
Closes #2363: Use arm64-compatible webdriver image.
Closes #2363: Use arm64-compatible webdriver image for lando.
Apr 28, 2023
tadean
approved these changes
Apr 28, 2023
trackleft
approved these changes
May 5, 2023
joeparsons
added
the
patch release
Issues to be included in the next patch release
label
May 18, 2023
joeparsons
added
the
backport
Changes to be back-ported to previous minor release branch
label
May 18, 2023
trackleft
pushed a commit
that referenced
this pull request
May 18, 2023
Co-authored-by: tadean <[email protected]>
trackleft
pushed a commit
that referenced
this pull request
May 18, 2023
Co-authored-by: tadean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Changes to be back-ported to previous minor release branch
bug
Something isn't working
ci
Continuous integration / automation
patch release
Issues to be included in the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the
drupal-ci/webdriver-chromedriver
docker image we have been using in our lando config withseleniarm/standalone-chromium
, which provides bothamd64
andarm64
builds. This should make it possible to run functional Javascript tests using lando on arm64 systems (e.g. Mac M1/M2 systems).Related issues
Closes #2363
How to test
Run
lando phpunit
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist