Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2363: Use arm64-compatible webdriver image for lando. #2364

Merged
merged 3 commits into from
May 5, 2023

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Apr 22, 2023

Description

Replaces the drupal-ci/webdriver-chromedriver docker image we have been using in our lando config with seleniarm/standalone-chromium, which provides both amd64 and arm64 builds. This should make it possible to run functional Javascript tests using lando on arm64 systems (e.g. Mac M1/M2 systems).

Related issues

Closes #2363

How to test

Run lando phpunit

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joeparsons joeparsons self-assigned this Apr 22, 2023
@joeparsons joeparsons added bug Something isn't working ci Continuous integration / automation labels Apr 22, 2023
trackleft
trackleft previously approved these changes Apr 22, 2023
Copy link
Member

@trackleft trackleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me

.lando.yml Outdated Show resolved Hide resolved
@tadean
Copy link
Contributor

tadean commented Apr 28, 2023

After merging main and making my commit suggestion above, all tests pass on amd64 architecture in local testing.

@joeparsons
Copy link
Member Author

After merging main and making my commit suggestion above, all tests pass on amd64 architecture in local testing.

Thanks @tadean!

@joeparsons joeparsons changed the title Closes #2363: Use arm64-compatible webdriver image. Closes #2363: Use arm64-compatible webdriver image for lando. Apr 28, 2023
@joeparsons joeparsons marked this pull request as ready for review April 28, 2023 17:37
@joeparsons joeparsons requested a review from a team as a code owner April 28, 2023 17:37
@trackleft trackleft merged commit dd716fe into main May 5, 2023
@trackleft trackleft deleted the issue/2363 branch May 5, 2023 18:21
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label May 18, 2023
@joeparsons joeparsons added the backport Changes to be back-ported to previous minor release branch label May 18, 2023
trackleft pushed a commit that referenced this pull request May 18, 2023
trackleft pushed a commit that referenced this pull request May 18, 2023
@trackleft trackleft mentioned this pull request Jun 16, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Changes to be back-ported to previous minor release branch bug Something isn't working ci Continuous integration / automation patch release Issues to be included in the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional JavaScript tests fail (crash) on arm64 macs using drupalci/webdriver-chromedriver:production
3 participants