Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2288 Fix broken az_barrio footer logo field validation #2292

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Mar 15, 2023

Description

See https://www.drupal.org/project/drupal/issues/59750

Related issues

#2288

How to test

Attempt to upload a logo in the az_barrio theme.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@trackleft trackleft requested a review from a team as a code owner March 15, 2023 00:42
Copy link
Contributor

@joshuasosa joshuasosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't replicate the issue when using az-quickstart-scaffolding, but can when using the direct az_quickstart repo. But I can confirm this change doesn't affect the former and fixes the latter.

@joeparsons joeparsons changed the title Fix broken az_barrio footer logo field Closes #2288 Fix broken az_barrio footer logo field Mar 15, 2023
@joeparsons joeparsons added the bug Something isn't working label Mar 15, 2023
@joeparsons joeparsons linked an issue Mar 15, 2023 that may be closed by this pull request
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Mar 15, 2023
@joeparsons joeparsons changed the title Closes #2288 Fix broken az_barrio footer logo field Closes #2288 Fix broken az_barrio footer logo field validation Mar 15, 2023
@joeparsons joeparsons merged commit bcf089e into main Mar 15, 2023
@joeparsons joeparsons deleted the issue/2288 branch March 15, 2023 17:16
@trackleft trackleft mentioned this pull request Jun 16, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch release Issues to be included in the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when changing Footer Logo
5 participants