Update drupal/search_exclude requirement from 2.0.0-beta2 to 3.0.0-beta1 #2193
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on drupal/search_exclude to permit the latest version. --- updated-dependencies: - dependency-name: drupal/search_exclude dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
There was a problem hiding this comment.
Is it correct that this module does not automatically exclude any nodes from search results? Both in Probo and in a Quickstart 2.5.1 sandbox, I created a new search page to exclude News and Person nodes, but even after disabling the other search pages and re-indexing the site, I still got search results for those nodes:
Instead, it seems this module simply provides some checkboxes hidden in "Advanced Search" which allow users to filter the results by content type:
|
After some further testing with both versions of search_exclude, it seems that once a node gets indexed it will always show up in search results, even if you modify the search page to exclude it. For example, if you modify the default "Content" search page to remove Carousel items from being excluded and then re-index the site, the Carousel items will continue to show up in search results even after you change the search page back to excluding Carousel items, set the site to re-index, and run cron. |
|
So, this module doesn't work at all then? |
|
It works as long as you don't make a change that causes the content you want excluded to be indexed. |
There was a problem hiding this comment.
I think it should be OK to apply this update. Sounds like the problem @bberndt-uaz encountered is an existing issue that we could consider contributing a patch for if needed.
joeparsons
deleted the
dependabot/composer/drupal/search_exclude-3.0.0-beta1
branch
Updates the requirements on drupal/search_exclude to permit the latest version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)