Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AZEnterpriseAttributesMigrationSync #3866

Closed
tadean opened this issue Nov 5, 2024 · 2 comments · Fixed by #3868
Closed

Update AZEnterpriseAttributesMigrationSync #3866

tadean opened this issue Nov 5, 2024 · 2 comments · Fixed by #3868
Assignees
@tadean
Labels
enhancement New feature or request

Comments

@tadean
Copy link
Contributor

tadean commented Nov 5, 2024

Motivation

AZEnterpriseAttributesMigrationSync's parent class, MigrationImportSync (in migrate_tools) has been changed in version 6.0.5 to no longer use state for its storage. We need to update our implementation to match.

This event subscriber is responsible for unpublishing enterprise attributes which disappear from the feed.

Describe the solution you'd like

AZEnterpriseAttributesMigrationSync should be refactored to not use state for storage.
@tadean tadean added the enhancement New feature or request label Nov 5, 2024
@tadean tadean self-assigned this Nov 5, 2024
@tadean tadean added this to 2.12.2 Nov 5, 2024
@github-project-automation github-project-automation bot moved this to Todo in 2.12.2 Nov 5, 2024
@tadean tadean mentioned this issue Nov 5, 2024
Closed
@trackleft
Copy link
Member

Hopefully we'll get their reported performance improvements.

@tadean
Copy link
Contributor Author

tadean commented Nov 5, 2024

https://www.drupal.org/project/migrate_tools/releases/6.0.5

tadean pushed a commit that referenced this issue Nov 5, 2024
Fixes #3866 Update AZEnterpriseAttributesMigrationSync
d92668f
@tadean tadean mentioned this issue Nov 6, 2024
Merged
32 tasks
@bberndt-uaz bberndt-uaz linked a pull request Nov 15, 2024 that will close this issue
Fixes #3866 Update AZEnterpriseAttributesMigrationSync, Migrate Tools #3868
Merged
32 tasks
@bberndt-uaz bberndt-uaz removed this from 2.12.2 Nov 15, 2024
@bberndt-uaz bberndt-uaz moved this from Todo to In Progress in 2.12.x Patch Release Issues Nov 15, 2024
trackleft pushed a commit that referenced this issue Dec 18, 2024
@tadean
Fixes #3866 Update AZEnterpriseAttributesMigrationSync, Migrate Tools (…
9c13f0d 
…#3868)

Co-authored-by: Troy Dean <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2.12.x Patch Release Issues Dec 18, 2024
joeparsons pushed a commit that referenced this issue Jan 10, 2025
@tadean @joeparsons
Fixes #3866 Update AZEnterpriseAttributesMigrationSync, Migrate Tools (…
1c9cbce 
…#3868)

Co-authored-by: Troy Dean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadean tadean

Labels
enhancement New feature or request
Projects
2.12.x Patch Release Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3866 Update AZEnterpriseAttributesMigrationSync, Migrate Tools az-digital/az_quickstart
2 participants
@trackleft @tadean