Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trellis Event Import Bulkform Issue #3556

Closed
tadean opened this issue Jul 19, 2024 · 2 comments · Fixed by #3558
Closed

Trellis Event Import Bulkform Issue #3556

tadean opened this issue Jul 19, 2024 · 2 comments · Fixed by #3558
Assignees
Labels
2.11.x only bug Something isn't working high priority Must get done for this milestone Integrations This relates to an integration into a central service.

Comments

@tadean
Copy link
Contributor

tadean commented Jul 19, 2024

Problem/Motivation

Beginning in 2.11, the Trellis Event Import Form throws the following error:

Exception: No entity type for field Id on view az_event_trellis_import in Drupal\views\Plugin\views\HandlerBase->getEntityType() (line 735 of /app/web/core/modules/views/src/Plugin/views/HandlerBase.php).

#0 /app/web/core/modules/views/src/Plugin/views/field/BulkForm.php(181): Drupal\views\Plugin\views\HandlerBase->getEntityType()
#1 /app/web/core/modules/views/src/Plugin/views/field/BulkForm.php(594): Drupal\views\Plugin\views\field\BulkForm->getEntityTypeId()

Seemingly this might be due to some changes in the BulkForm class in 10.3.

To Reproduce

Visit /admin/trellis-event-importer

Proposed resolution

Update the BulkForm child class AZEventTrellisViewsField to avoid the issue

Expected behavior

Event importer should not crash on view.

@tadean tadean added bug Something isn't working high priority Must get done for this milestone Integrations This relates to an integration into a central service. labels Jul 19, 2024
@tadean tadean self-assigned this Jul 19, 2024
@joeparsons
Copy link
Member

Possibly related Drupal 10.3 change records:

@tadean
Copy link
Contributor Author

tadean commented Jul 19, 2024

Looks like this is due to Add an API for allowing modules to mark their forms as workspace-safe

Bulkform's implementation for checking whether a bulkform is safe for a workspace involves checking if the entity backing the field is tagged as workspace safe.

Since there is no entity backing the field in this case, that's understandable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only bug Something isn't working high priority Must get done for this milestone Integrations This relates to an integration into a central service.
Projects
None yet
2 participants