Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the make latest flag when creating a release. #3199

Closed
trackleft opened this issue Feb 21, 2024 · 1 comment · Fixed by #3841
Closed

Allow setting the make latest flag when creating a release. #3199

trackleft opened this issue Feb 21, 2024 · 1 comment · Fixed by #3841
Labels
ci Continuous integration / automation low priority Nice to have for this milestone, can be pushed out if needed proposal Proposed change to how something works (usually larger or more fundamental than a feature request)

Comments

@trackleft
Copy link
Member

trackleft commented Feb 21, 2024

Quickstart supports two release branches (minimum) at any given time.
We need to create releases for both the latest release branch and the previous release branch.
One release (from the latest release branch) should be marked latest.
One release (from the previous release branch) should not be marked latest.

At the moment, the action we use does not allow for this. https://github.com/az-digital/az_quickstart/blob/main/.github/workflows/create-release.yml#L52

The github action "create release" which is an archived repo, recommends the following actions for this.
https://github.com/actions/create-release

elgohr/Github-Release-Action
marvinpinto/action-automatic-releases
softprops/action-gh-release <-- the one we currently use that doesn't allow marking a release as latest.
ncipollo/release-action <-- This one allows marking a release as latest.

I think we should also take the latest flag into account with this ticket: az-digital/az-quickstart-pantheon#51

See softprops/action-gh-release#304

@trackleft trackleft added ci Continuous integration / automation proposal Proposed change to how something works (usually larger or more fundamental than a feature request) low priority Nice to have for this milestone, can be pushed out if needed labels Feb 21, 2024
@trackleft
Copy link
Member Author

the action we use just release v2, which does what we need .
https://github.com/softprops/action-gh-release/releases/tag/v2.0.1

@trackleft trackleft changed the title Switch create release action from softprops/action-gh-release to another that allows setting the make latest flag when creating a release. Allow setting the make latest flag when creating a release. Mar 12, 2024
@danahertzberg danahertzberg modified the milestones: 2.9.x Patch Release Issues, 2.10.x Patch Release Issues Aug 23, 2024
trackleft added a commit that referenced this issue Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration / automation low priority Nice to have for this milestone, can be pushed out if needed proposal Proposed change to how something works (usually larger or more fundamental than a feature request)
Projects
No open projects
Status: Todo
2 participants