Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1197 - Make form labels visually distinguishable from description text #1252

Merged
merged 12 commits into from
Aug 9, 2024

Conversation

akslay
Copy link
Contributor

@akslay akslay commented Jul 3, 2024

Makes form labels visually distinguishable from description text by increasing their size and boldness. Checkbox/radio labels are excluded from this change.

Originally stemmed from az-digital/az_quickstart#3249
Closes #1197

Review link: https://review.digital.arizona.edu/arizona-bootstrap/issue/1197/docs/5.0/components/forms/

@akslay akslay self-assigned this Jul 3, 2024
@akslay akslay marked this pull request as ready for review July 3, 2024 21:57
mmunro-ltrr
mmunro-ltrr previously approved these changes Jul 19, 2024
joeparsons
joeparsons previously approved these changes Jul 19, 2024
@joeparsons joeparsons added the backport Backport to 2.x label Jul 19, 2024
@joshuasosa
Copy link

Should .col-form-label, .col-form-label-sm, and .col-form-label-lg get bolds? For example, "Radios" is not bolded here. ("Checkbox" doesn't have col-form-label and wouldn't get bold in this example, though maybe it should get the class.)

@mmunro-ltrr mmunro-ltrr dismissed stale reviews from joeparsons and themself via ee1bde6 July 26, 2024 16:58
mmunro-ltrr
mmunro-ltrr previously approved these changes Jul 26, 2024
joeparsons
joeparsons previously approved these changes Jul 26, 2024
@joeparsons
Copy link
Member

joeparsons commented Jul 26, 2024

Should .col-form-label, .col-form-label-sm, and .col-form-label-lg get bolds? For example, "Radios" is not bolded here. ("Checkbox" doesn't have col-form-label and wouldn't get bold in this example, though maybe it should get the class.)

We discussed this in our 2024-07-26 Friday meeting and we think this was intentional / by design. The Bootstrap 5 docs included in Arizona Bootstrap still need a lot of work so we're not sure about that but we can take a closer look in the follow-up backport to 2.x PR.

@akslay Any thoughts on this?

@danahertzberg
Copy link
Contributor

@danahertzberg danahertzberg dismissed stale reviews from joeparsons and mmunro-ltrr via a6266aa July 26, 2024 19:29
scss/_forms.scss Outdated Show resolved Hide resolved
scss/_forms.scss Outdated Show resolved Hide resolved
@danahertzberg
Copy link
Contributor

@akslay will make these changes before Friday's meeting per Slack.

mmunro-ltrr and others added 2 commits August 2, 2024 10:46
Co-authored-by: Dana Hertzberg <[email protected]>
Co-authored-by: Dana Hertzberg <[email protected]>
@mmunro-ltrr
Copy link
Member

mmunro-ltrr commented Aug 2, 2024

I'm finding some linting errors on a local build, too, so will be committing a further change....
The problem isn't just appeasing stylelint: the sizing classes on some labels are broken, so currently
https://review.digital.arizona.edu/arizona-bootstrap/issue/1197/docs/5.0/components/forms/#horizontal-form-label-sizing
doesn't match
https://digital.arizona.edu/arizona-bootstrap/docs/2.0/components/forms/#horizontal-form-label-sizing

@mmunro-ltrr mmunro-ltrr marked this pull request as ready for review August 8, 2024 22:53
@joeparsons joeparsons merged commit 0981f86 into main Aug 9, 2024
2 checks passed
@joeparsons joeparsons deleted the issue/1197 branch August 9, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Make form labels visually distinguishable from description text
6 participants