Closes #1207: Refactor accordions to use Flexbox. #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmunro-ltrr
added
bug
This was
linked to
issues
Apr 18, 2024
mmunro-ltrr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple replacement of
display: blockwithdisplay: flexto resolve Issue #1192 extended thetext-decoration: underlinestyling from the accordion title to the arrow toggle icon on the left; to avoid such behavior, this PR implements the approach of @danahertzberg by limiting the scope of text styling with a<span>element. Note that this approach does require modifications to existing markup, or the toggle icon will still appear underlined.