Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update review site action to use the login-action to log into GitHub Container Registry. #1284

Closed
trackleft opened this issue Sep 4, 2024 · 0 comments · Fixed by #1285
Closed
Assignees

Comments

@trackleft
Copy link
Member

Motivation

image

Proposed Resolution

Currently we do this

      - name: Docker authentication
        run: |
          docker login "$AZ_DOCKER_REGISTRY" -u "$GITHUB_ACTOR" -p ${{ secrets.AZ_DOCKER_REGISTRY_TOKEN }}

Change how we log into the docker registry to

https://github.com/docker/login-action#github-container-registry

- name: Login to GitHub Container Registry
        uses: docker/login-action@v1
        with:
          registry: $AZ_DOCKER_REGISTRY
          username: $GITHUB_ACTOR
          password:  ${{ secrets.AZ_DOCKER_REGISTRY_TOKEN }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant