Skip to content

Commit

Permalink
Closes #887: Address off-canvas menu usability issues on iOS (#899)
Browse files Browse the repository at this point in the history
Co-authored-by: joeparsons <[email protected]>
Co-authored-by: Dana Hertzberg <[email protected]>
  • Loading branch information
3 people authored Aug 25, 2023
1 parent dfe7dc0 commit 4b664b8
Show file tree
Hide file tree
Showing 7 changed files with 381 additions and 836 deletions.
4 changes: 3 additions & 1 deletion dist/css/arizona-bootstrap.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/css/arizona-bootstrap.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/css/arizona-bootstrap.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/css/arizona-bootstrap.min.css.map

Large diffs are not rendered by default.

1,167 changes: 344 additions & 823 deletions package-lock.json

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion scss/_navbar-offcanvas.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
display: none;
}
.offcanvas-toggle-body-freeze {
overflow-y: hidden;
overflow: hidden;
}
@keyframes fadein {
from {
Expand Down Expand Up @@ -39,7 +39,9 @@
width: 325px;
max-width: 90%;
height: 100vh;
height: 100svh;
max-height: 100vh;
max-height: 100svh;
overflow-y: hidden;
background-color: $navbar-offcanvas-bg;
border: none;
Expand Down
36 changes: 28 additions & 8 deletions site/content/docs/2.0/components/navbar-off-canvas.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,24 +51,44 @@ Adding the `.navbar-offcanvas` class to your `<nav>` will incorporate an off-can
</li>
<li class="nav-item nav-item-parent dropdown keep-open">
<button class="nav-link dropdown-toggle" id="navbarDropdown4" data-toggle="dropdown" data-display="static" aria-expanded="false">
Admissions
First Parent
</button>
<div class="dropdown-menu" role="menu" aria-labelledby="navbarDropdown4">
<a class="dropdown-item" href="#">Admissions Overview</a>
<a class="dropdown-item" href="#">Another action</a>
<a class="dropdown-item" href="#">Item 1</a>
<a class="dropdown-item" href="#">Item 2</a>
<a class="dropdown-item" href="#">Item 3</a>
<a class="dropdown-item" href="#">Item 4</a>
<div class="dropdown-divider"></div>
<a class="dropdown-item" href="#">Something else here</a>
<a class="dropdown-item" href="#">Item 5</a>
<a class="dropdown-item" href="#">Item 6</a>
</div>
</li>
<li class="nav-item nav-item-parent dropdown keep-open">
<button class="nav-link dropdown-toggle" id="navbarDropdown5" data-toggle="dropdown" data-display="static" aria-expanded="false">
Dropdown
Second Parent
</button>
<div class="dropdown-menu" role="menu" aria-labelledby="navbarDropdown5">
<a class="dropdown-item" href="#">Action</a>
<a class="dropdown-item" href="#">Another action</a>
<a class="dropdown-item" href="#">Item 1</a>
<a class="dropdown-item" href="#">Item 2</a>
<a class="dropdown-item" href="#">Item 3</a>
<a class="dropdown-item" href="#">Item 4</a>
<div class="dropdown-divider"></div>
<a class="dropdown-item" href="#">Something else here</a>
<a class="dropdown-item" href="#">Item 5</a>
<a class="dropdown-item" href="#">Item 6</a>
</div>
</li>
<li class="nav-item nav-item-parent dropdown keep-open">
<button class="nav-link dropdown-toggle" id="navbarDropdown6" data-toggle="dropdown" data-display="static" aria-expanded="false">
Third Parent
</button>
<div class="dropdown-menu" role="menu" aria-labelledby="navbarDropdown6">
<a class="dropdown-item" href="#">Item 1</a>
<a class="dropdown-item" href="#">Item 2</a>
<a class="dropdown-item" href="#">Item 3</a>
<a class="dropdown-item" href="#">Item 4</a>
<div class="dropdown-divider"></div>
<a class="dropdown-item" href="#">Item 5</a>
<a class="dropdown-item" href="#">Item 6</a>
</div>
</li>
<li class="nav-item nav-item-parent">
Expand Down

0 comments on commit 4b664b8

Please sign in to comment.