Fix panic by disabling exceptions and more BIOS bug fixes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be made safe by checking cop0::Status before the syscall but that gets rid of the benefit that this function immediately disables exceptions before any loads from cop0.
This reverts commit df12e35.
The example BIOS previously had very random bugs because panic was not
thread-safe. Essentially the loop {} was being ignored because if the exception
handler changed threads. This commit fixes that by ensuring that panic happens
in a critical section. A syscall is used to minimize the chance that an
exception happens between panic's prologue and the critical section call but to
really ensure this panic needs to be a naked function starting with the syscall.
I'm not sure if this is worth it, but it may be a good idea to add a
thread-aware panic handler in the example BIOS.
The panic function was also not reentrant. Normally this should not occur
because the panic function should be simple enough that it doesn't panic, but it
was happening because of a typo in the framebuffer handling introduced when I
added some video mode things. To make it reentrant I just use a static mut flag
since it's already in a critical section and previous iterations won't hold onto
mutable references.
This fixes a bug that was causing nested panics in a non-reentrant panic handler
In case of nested panics (e.g. cause by the CStr limit in println) this allows execution to continue until the second panic message.
There was a panic message in linked_list_allocator in the BIOS that needed a larger buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully the BIOS should be bug-free enough to be useful for CI now. See commit messages for details on other fixes.